From: Erik Fastermann <e.fastermann@proxmox.com>
To: pmg-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH pmg-api v2] fix #7187: report: add ethtool output for physical interfaces
Date: Wed, 13 May 2026 10:22:52 +0200 [thread overview]
Message-ID: <20260513082252.6825-1-e.fastermann@proxmox.com> (raw)
Adding ethtool output to pmg-system-report provides visibility into
actual and supported NIC link speeds, making it much easier to diagnose
network performance issues, negotiation failures, and configuration
mismatches. It also reduces support back-and-forth.
The implementation mirrors the change in pve-manager, as the report
functionality is similar in both projects.
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
NOTE: A similar patch was applied to all products:
pmg, pve, pbs, pdm.
changes since v1:
* add a more detailed commit message explaining the rational
* wrap in eval to prevent errors crashing the report
* use PVE::Tools::shellquote to prevent injection errors
src/PMG/Report.pm | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/src/PMG/Report.pm b/src/PMG/Report.pm
index 84d1b88..d5761e0 100644
--- a/src/PMG/Report.pm
+++ b/src/PMG/Report.pm
@@ -4,6 +4,7 @@ use strict;
use warnings;
use Mail::SpamAssassin::DnsResolver;
+use PVE::IPRoute2;
use PVE::Tools;
use PMG::Utils;
@@ -58,6 +59,20 @@ my $report_def = {
],
};
+eval {
+ my $interfaces = PVE::IPRoute2::ip_link_details();
+
+ for my $iface (sort keys %{$interfaces}) {
+ if (PVE::IPRoute2::ip_link_is_physical($interfaces->{$iface})) {
+ push @{ $report_def->{network} }, "ethtool " . PVE::Tools::shellquote($iface);
+ }
+ }
+};
+
+if ($@) {
+ print STDERR "building ethtool commands failed: $@";
+}
+
my @report_order = ('general', 'storage', 'network', 'firewall', 'cluster', 'pmg');
my $report = '';
--
2.47.3
reply other threads:[~2026-05-13 8:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513082252.6825-1-e.fastermann@proxmox.com \
--to=e.fastermann@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox