public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [PATCH pmg-docs] pmgconfig: note pmg-smtp-filter needs restart for custom check script
Date: Thu, 11 Jun 2026 13:38:10 +0200	[thread overview]
Message-ID: <20260611133810.5608a2f8@rosa.proxmox.com> (raw)
In-Reply-To: <0f5d0733-a29b-4a5a-9651-8bfef4f0a5f2@proxmox.com>

On Thu, 11 Jun 2026 12:40:57 +0200
Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:

> On 11/06/2026 11:38, Dominik Csapak wrote:
> > It's implied by other parts of the docs, but not explicitely stated, so
> > do that to avoid confusion.  
> 
> Should we rather handle that automatically too like Stoiko's 'log-headers'
> patch?
Hm - I talked with Dominik off-list about that - and I argued that the
script needs to be put in place by the admin anyways, and that I'd expect
them to edit /etc/pmg/pmg.conf in place directly (which would not get
noticed by pmgdaemon) - but since
* there might be an use-case where admins disable the custom-check in some
  automated fashion (not that I have a good use-case in mind)
* afaict `pmgconfig sync -restart 1` would also trigger the reload if it's
  added to the list.

TBH - not sure if it will make the UX better for many users, but having a
bit of consistency here might cause fewer confused questions why this
particular setting does not trigger the reload compared to many others.. -
so am not opposed to adding it.
(not sure if we did not simply skip it by mistake when the reload
triggering of smtp-filter was added)




      parent reply	other threads:[~2026-06-11 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11  9:39 [PATCH pmg-docs] pmgconfig: note pmg-smtp-filter needs restart for custom check script Dominik Csapak
2026-06-11 10:40 ` Thomas Lamprecht
2026-06-11 11:28   ` Dominik Csapak
2026-06-11 11:38   ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260611133810.5608a2f8@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal