From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6D6241FF13C for ; Thu, 11 Jun 2026 13:38:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44947371; Thu, 11 Jun 2026 13:38:27 +0200 (CEST) Date: Thu, 11 Jun 2026 13:38:10 +0200 From: Stoiko Ivanov To: Thomas Lamprecht Subject: Re: [PATCH pmg-docs] pmgconfig: note pmg-smtp-filter needs restart for custom check script Message-ID: <20260611133810.5608a2f8@rosa.proxmox.com> In-Reply-To: <0f5d0733-a29b-4a5a-9651-8bfef4f0a5f2@proxmox.com> References: <20260611093908.1421564-1-d.csapak@proxmox.com> <0f5d0733-a29b-4a5a-9651-8bfef4f0a5f2@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781177855633 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Q7ROR6Y3ULUCZD2TCY2XEIWVK7TLHDAX X-Message-ID-Hash: Q7ROR6Y3ULUCZD2TCY2XEIWVK7TLHDAX X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pmg-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 11 Jun 2026 12:40:57 +0200 Thomas Lamprecht wrote: > On 11/06/2026 11:38, Dominik Csapak wrote: > > It's implied by other parts of the docs, but not explicitely stated, so > > do that to avoid confusion. > > Should we rather handle that automatically too like Stoiko's 'log-headers' > patch? Hm - I talked with Dominik off-list about that - and I argued that the script needs to be put in place by the admin anyways, and that I'd expect them to edit /etc/pmg/pmg.conf in place directly (which would not get noticed by pmgdaemon) - but since * there might be an use-case where admins disable the custom-check in some automated fashion (not that I have a good use-case in mind) * afaict `pmgconfig sync -restart 1` would also trigger the reload if it's added to the list. TBH - not sure if it will make the UX better for many users, but having a bit of consistency here might cause fewer confused questions why this particular setting does not trigger the reload compared to many others.. - so am not opposed to adding it. (not sure if we did not simply skip it by mistake when the reload triggering of smtp-filter was added)