public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [PATCH pmg-docs] pmgconfig: note pmg-smtp-filter needs restart for custom check script
Date: Thu, 11 Jun 2026 13:28:07 +0200	[thread overview]
Message-ID: <6ca6386f-972e-44dc-981c-2c934a04e811@proxmox.com> (raw)
In-Reply-To: <0f5d0733-a29b-4a5a-9651-8bfef4f0a5f2@proxmox.com>



On 6/11/26 12:40 PM, Thomas Lamprecht wrote:
> On 11/06/2026 11:38, Dominik Csapak wrote:
>> It's implied by other parts of the docs, but not explicitely stated, so
>> do that to avoid confusion.
> 
> Should we rather handle that automatically too like Stoiko's 'log-headers'
> patch?


we could, but makes less sense IMO since the user has to be on the cli 
anyway for putting the script somewhere?

if we'd put it on the gui, i'd say yes definitely, but currently it
won't gain us much. We'd then have to either
* write another note to do 'pmgconfig sync' (maybe with '--restart 1' ?)
* or add a new 'pmgconfig set' command to the cli (which would be
   beneficial in any case i guess) and document that in the docs.

> 
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   pmgconfig.adoc | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/pmgconfig.adoc b/pmgconfig.adoc
>> index 00a988e..34dbecc 100644
>> --- a/pmgconfig.adoc
>> +++ b/pmgconfig.adoc
>> @@ -1011,6 +1011,13 @@ section: admin
>>   The location of the custom check executable can also be set there with the key
>>   `custom_check_path` and defaults to `/usr/local/bin/pmg-custom-check`.
>>   
>> +To enable the changes to the custom check configuration, `pmg-smtp-filter` has
>> +to be restarted:
>> +
>> +----
>> +# systemctl restart pmg-smtp-filter.service
>> +----
>> +
>>   NOTE: The custom check executable runs as the unprivileged
>>   `pmg-smtp-filter` daemon user. It cannot elevate privileges with tools
>>   like `sudo`, as the service runs with the systemd `NoNewPrivileges`
> 





  reply	other threads:[~2026-06-11 11:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11  9:39 [PATCH pmg-docs] pmgconfig: note pmg-smtp-filter needs restart for custom check script Dominik Csapak
2026-06-11 10:40 ` Thomas Lamprecht
2026-06-11 11:28   ` Dominik Csapak [this message]
2026-06-11 11:38   ` Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ca6386f-972e-44dc-981c-2c934a04e811@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal