public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list
@ 2026-06-08 14:33 Dominik Csapak
  2026-06-08 14:33 ` [PATCH yew-widget-toolkit-assets 1/2] slidable: make text non-wrapping Dominik Csapak
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dominik Csapak @ 2026-06-08 14:33 UTC (permalink / raw)
  To: pmg-devel

instead of always showing the 'mark as seen' action.


proxmox-yew-widget-toolkit-assets:

Dominik Csapak (1):
  slidable: make text non-wrapping

 scss/_slidable.scss | 2 ++
 1 file changed, 2 insertions(+)


pmg-yew-quarantine-gui:

Dominik Csapak (1):
  spam list: show seen/unseen slidable action depending on state

 src/spam_list.rs | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)


Summary over all repositories:
  2 files changed, 13 insertions(+), 5 deletions(-)

-- 
Generated by murpp 0.11.0




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH yew-widget-toolkit-assets 1/2] slidable: make text non-wrapping
  2026-06-08 14:33 [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list Dominik Csapak
@ 2026-06-08 14:33 ` Dominik Csapak
  2026-06-08 14:33 ` [PATCH pmg-yew-quarantine-gui 2/2] spam list: show seen/unseen slidable action depending on state Dominik Csapak
  2026-06-09 15:28 ` applied: [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Dominik Csapak @ 2026-06-08 14:33 UTC (permalink / raw)
  To: pmg-devel

For long labels,  the text would wrap and it would get too tall and
break alignment. Since the text and icons should be aligned with each
other, don't let the text wrap here.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 scss/_slidable.scss | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scss/_slidable.scss b/scss/_slidable.scss
index 821d554..8a1a611 100644
--- a/scss/_slidable.scss
+++ b/scss/_slidable.scss
@@ -25,5 +25,7 @@
     justify-content: center;
     align-items: center;
 
+    text-wrap: nowrap;
+
     @include state-layer();
 }
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH pmg-yew-quarantine-gui 2/2] spam list: show seen/unseen slidable action depending on state
  2026-06-08 14:33 [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list Dominik Csapak
  2026-06-08 14:33 ` [PATCH yew-widget-toolkit-assets 1/2] slidable: make text non-wrapping Dominik Csapak
@ 2026-06-08 14:33 ` Dominik Csapak
  2026-06-09 15:28 ` applied: [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Dominik Csapak @ 2026-06-08 14:33 UTC (permalink / raw)
  To: pmg-devel

Show a 'mark as unseen' action instead of 'mark as seen' if it's already
seen.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/spam_list.rs | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/spam_list.rs b/src/spam_list.rs
index a7f1bd2..7a34df8 100644
--- a/src/spam_list.rs
+++ b/src/spam_list.rs
@@ -298,6 +298,16 @@ fn render_list_item(
                 .with_child(score)
                 .with_child(Fa::new("chevron-right").class(Opacity::Half));
 
+            let seen_action = if item.seen {
+                SlidableAction::new(tr!("Mark as Unseen"))
+                    .icon_class("fa fa-eye-slash")
+                    .on_activate(make_cb(MailAction::MarkUnseen))
+            } else {
+                SlidableAction::new(tr!("Mark as Seen"))
+                    .icon_class("fa fa-eye")
+                    .on_activate(make_cb(MailAction::MarkSeen))
+            };
+
             Slidable::new(main)
                 .class(Overflow::Auto)
                 .on_tap({
@@ -324,11 +334,7 @@ fn render_list_item(
                                 .icon_class("fa fa-check")
                                 .on_activate(make_cb(MailAction::Welcomelist)),
                         )
-                        .with_child(
-                            SlidableAction::new(tr!("Mark as Seen"))
-                                .icon_class("fa fa-eye")
-                                .on_activate(make_cb(MailAction::MarkSeen)),
-                        ),
+                        .with_child(seen_action),
                 )
                 .right_actions(
                     Row::new()
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* applied: [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list
  2026-06-08 14:33 [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list Dominik Csapak
  2026-06-08 14:33 ` [PATCH yew-widget-toolkit-assets 1/2] slidable: make text non-wrapping Dominik Csapak
  2026-06-08 14:33 ` [PATCH pmg-yew-quarantine-gui 2/2] spam list: show seen/unseen slidable action depending on state Dominik Csapak
@ 2026-06-09 15:28 ` Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2026-06-09 15:28 UTC (permalink / raw)
  To: pmg-devel, Dominik Csapak

On Mon, 08 Jun 2026 16:33:08 +0200, Dominik Csapak wrote:
> instead of always showing the 'mark as seen' action.
> 
> 
> proxmox-yew-widget-toolkit-assets:
> 
> Dominik Csapak (1):
>   slidable: make text non-wrapping
> 
> [...]

Applied and updated pwt-assets submodule, thanks!

[1/1] spam list: show seen/unseen slidable action depending on state
      commit: 6c3d6aa7fa466554f3d76ab55b2b1975f01722ca




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-06-09 15:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-08 14:33 [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list Dominik Csapak
2026-06-08 14:33 ` [PATCH yew-widget-toolkit-assets 1/2] slidable: make text non-wrapping Dominik Csapak
2026-06-08 14:33 ` [PATCH pmg-yew-quarantine-gui 2/2] spam list: show seen/unseen slidable action depending on state Dominik Csapak
2026-06-09 15:28 ` applied: [PATCH pmg-yew-quarantine-gui/yew-widget-toolkit-assets 0/2] add 'mark as unseen' action in spam list Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal