public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] applied: [PATCH yew-widget-toolkit/proxmox-api-types/pdm] overhaul remote wizard
Date: Thu, 19 Dec 2024 13:35:47 +0100	[thread overview]
Message-ID: <ebab4b63-dc2f-4568-affe-ad659e54b4fa@proxmox.com> (raw)
In-Reply-To: <88f01ff3-983b-46e0-8b41-f79e59730ef3@proxmox.com>

On 12/19/24 13:31, Thomas Lamprecht wrote:
> Am 19.12.24 um 13:09 schrieb Dominik Csapak:
>> reorganize how the wizard is setup, by
>> * first only requiring hostname (+ fingerprint)
>> * then require a name + credentials
>> * then the endpoint list as before
>> * then the summary as before
>>
>> Not super sure about the name for the 'realms' api endpoint, maybe
>> 'scan-realms' or something would be better?
>>
>> The widget toolkit patch is not strictly required, but the layout with
>> the radio buttons is slightly incorrect without it.
>>
>> promxox-yew-widget-toolkit:
>>
>> Dominik Csapak (1):
>>    widget: input panel: use correct column for custom childs
>>
>>   src/widget/input_panel.rs | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> promxox-api-types:
>>
>> Dominik Csapak (1):
>>    add /access/domains GET call
>>
>>   pve-api-types/generate.pl            |  7 +++-
>>   pve-api-types/src/generated/code.rs  | 12 ++++++-
>>   pve-api-types/src/generated/types.rs | 51 ++++++++++++++++++++++++++++
>>   3 files changed, 68 insertions(+), 2 deletions(-)
>>
>> proxmox-datacenter-manager:
>>
>> Dominik Csapak (3):
>>    server: api: add 'realms' add point for PVE
>>    pdm-client: expose `ListRealm` type
>>    ui: restructure wizard to have a better flow
>>
>>   lib/pdm-client/src/lib.rs             |   2 +
>>   server/src/api/pve/mod.rs             |  52 +++-
>>   ui/src/remotes/add_wizard.rs          |  37 ++-
>>   ui/src/remotes/mod.rs                 |   5 +-
>>   ui/src/remotes/wizard_page_connect.rs | 115 ++++-----
>>   ui/src/remotes/wizard_page_info.rs    | 336 ++++++++++++++++++++++----
>>   6 files changed, 415 insertions(+), 132 deletions(-)
>>
> 
> 
> applied series, thanks!
> 
> we might want to place realm and user closer together, maybe besides each
> other, not sure though.
> 
> As unlike the login window, which you probably used as template, one always
> needs to select the realm here (or we auto-select the first/default one too,
> then it might be OK as is)

yeah this was the fastest i could come up with.
I couldn't reuse the realm selector from the login easily
due to that not being able to 'preload' the realms, and i did
not want to query them twice unnecessarily

I'll extend the realm selector from proxmox-yew-comp
with that ability and reuse that then, not sure how long I need for that though...



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2024-12-19 12:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 12:09 [pdm-devel] " Dominik Csapak
2024-12-19 12:09 ` [pdm-devel] [PATCH yew-widget-toolkit 1/1] widget: input panel: use correct column for custom childs Dominik Csapak
2024-12-19 12:22   ` [pdm-devel] applied: " Thomas Lamprecht
2024-12-19 12:09 ` [pdm-devel] [PATCH proxmox-api-types 1/1] add /access/domains GET call Dominik Csapak
2024-12-19 12:22   ` [pdm-devel] applied: " Thomas Lamprecht
2024-12-19 12:09 ` [pdm-devel] [PATCH datacenter-manager 1/3] server: api: add 'realms' add point for PVE Dominik Csapak
2024-12-19 12:09 ` [pdm-devel] [PATCH datacenter-manager 2/3] pdm-client: expose `ListRealm` type Dominik Csapak
2024-12-19 12:09 ` [pdm-devel] [PATCH datacenter-manager 3/3] ui: restructure wizard to have a better flow Dominik Csapak
2024-12-19 12:31 ` [pdm-devel] applied: [PATCH yew-widget-toolkit/proxmox-api-types/pdm] overhaul remote wizard Thomas Lamprecht
2024-12-19 12:35   ` Dominik Csapak [this message]
2024-12-19 12:40     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebab4b63-dc2f-4568-affe-ad659e54b4fa@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal