From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pdm-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1991C1FF163 for <inbox@lore.proxmox.com>; Thu, 19 Dec 2024 13:36:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 593EE4BD8; Thu, 19 Dec 2024 13:36:21 +0100 (CET) Message-ID: <ebab4b63-dc2f-4568-affe-ad659e54b4fa@proxmox.com> Date: Thu, 19 Dec 2024 13:35:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox Datacenter Manager development discussion <pdm-devel@lists.proxmox.com> References: <20241219120920.2046373-1-d.csapak@proxmox.com> <88f01ff3-983b-46e0-8b41-f79e59730ef3@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <88f01ff3-983b-46e0-8b41-f79e59730ef3@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.134 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] applied: [PATCH yew-widget-toolkit/proxmox-api-types/pdm] overhaul remote wizard X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion <pdm-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/> List-Post: <mailto:pdm-devel@lists.proxmox.com> List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Datacenter Manager development discussion <pdm-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com> On 12/19/24 13:31, Thomas Lamprecht wrote: > Am 19.12.24 um 13:09 schrieb Dominik Csapak: >> reorganize how the wizard is setup, by >> * first only requiring hostname (+ fingerprint) >> * then require a name + credentials >> * then the endpoint list as before >> * then the summary as before >> >> Not super sure about the name for the 'realms' api endpoint, maybe >> 'scan-realms' or something would be better? >> >> The widget toolkit patch is not strictly required, but the layout with >> the radio buttons is slightly incorrect without it. >> >> promxox-yew-widget-toolkit: >> >> Dominik Csapak (1): >> widget: input panel: use correct column for custom childs >> >> src/widget/input_panel.rs | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> promxox-api-types: >> >> Dominik Csapak (1): >> add /access/domains GET call >> >> pve-api-types/generate.pl | 7 +++- >> pve-api-types/src/generated/code.rs | 12 ++++++- >> pve-api-types/src/generated/types.rs | 51 ++++++++++++++++++++++++++++ >> 3 files changed, 68 insertions(+), 2 deletions(-) >> >> proxmox-datacenter-manager: >> >> Dominik Csapak (3): >> server: api: add 'realms' add point for PVE >> pdm-client: expose `ListRealm` type >> ui: restructure wizard to have a better flow >> >> lib/pdm-client/src/lib.rs | 2 + >> server/src/api/pve/mod.rs | 52 +++- >> ui/src/remotes/add_wizard.rs | 37 ++- >> ui/src/remotes/mod.rs | 5 +- >> ui/src/remotes/wizard_page_connect.rs | 115 ++++----- >> ui/src/remotes/wizard_page_info.rs | 336 ++++++++++++++++++++++---- >> 6 files changed, 415 insertions(+), 132 deletions(-) >> > > > applied series, thanks! > > we might want to place realm and user closer together, maybe besides each > other, not sure though. > > As unlike the login window, which you probably used as template, one always > needs to select the realm here (or we auto-select the first/default one too, > then it might be OK as is) yeah this was the fastest i could come up with. I couldn't reuse the realm selector from the login easily due to that not being able to 'preload' the realms, and i did not want to query them twice unnecessarily I'll extend the realm selector from proxmox-yew-comp with that ability and reuse that then, not sure how long I need for that though... _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel