Re: [PATCH datacenter-manager/yew-widget-toolkit 0/3] ui: persist the main menus expanded state

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu Aug 20, 2026 at 10:17 AM CEST, Dominik Csapak wrote:
> By saving the state in the browsers local storage.
>
> It also fixes an issue where menus that were collapsed by default wouldn't open
> on the first click.
>
> Note that for the pdm patches, pwt must be bumped and the new version must be
> recorded in Cargo.toml.
>
>
> proxmox-yew-widget-toolki:
>
> Dominik Csapak (2):
>   widget: navigation drawer: fix first open for default collapsed menus
>   widget: navigation drawer: allow persisting the expanded state
>
>  src/widget/nav/navigation_drawer.rs | 138 +++++++++++++++++++++++-----
>  1 file changed, 115 insertions(+), 23 deletions(-)
>
>
> proxmox-datacenter-manager:
>
> Dominik Csapak (1):
>   ui: main menu: make expanded/collapsed state persistent
>
>  ui/src/main_menu.rs | 1 +
>  1 file changed, 1 insertion(+)
>
>
> Summary over all repositories:
>   2 files changed, 116 insertions(+), 23 deletions(-)


LGTM in general, works fine and the code seems good too.

One thought, looking at the saved state in the web inspector in Firefox:
Would it maybe make sense for future extensions to slightly update the
serialized format from 

["sdn","administration"]

to something like:

{ collapsed: ["sdn", "administration"]}

That would make it much easier to add other keys as well in the future,
if we need to store additional state.

Not a blocker from my side though:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>