Re: [PATCH datacenter-manager/yew-widget-toolkit 0/3] ui: persist the main menus expanded state

["Lukas Wagner" <l.wagner@proxmox.com>]

On Mon Aug 31, 2026 at 3:11 PM CEST, Dominik Csapak wrote:
>> 
>> LGTM in general, works fine and the code seems good too.
>> 
>> One thought, looking at the saved state in the web inspector in Firefox:
>> Would it maybe make sense for future extensions to slightly update the
>> serialized format from
>> 
>> ["sdn","administration"]
>> 
>> to something like:
>> 
>> { collapsed: ["sdn", "administration"]}
>> 
>> That would make it much easier to add other keys as well in the future,
>> if we need to store additional state.
>
> it's actually not collapsed, but changed from the default
> (the main menu in pdm just happens to default to all expanded)
>
> so it would be { "changed": [...] }
>
> would that be ok?

Maybe "changed-collapsed" so that it conveys that this is about the
collpase/expanded state and not anything else?

>
> we could of course do this in the future and interpret
> an array as just the changed list and migrate automatically.
>
> in practice this would look like (rough pseude code):
>
> let try1: Result<NewStateFormat, _> = input.parse();
> match try1 {
>     Ok(state) => { /* return the state */ }
>     Err(err) => {
>         let legacy: Result<OldStateFormat, _> = input.parse();
>         // either take legacy and convert to new state
>         // or return original error 'err'
>     }
> }

Yeah, migrating the format is of course also possible in the future, but
since this is completely new code, I'd favor making it extensible right
away.

Thanks!