Re: [PATCH datacenter-manager/yew-widget-toolkit 0/3] ui: persist the main menus expanded state

[Dominik Csapak <d.csapak@proxmox.com>]

On 8/31/26 3:02 PM, Lukas Wagner wrote:
> On Thu Aug 20, 2026 at 10:17 AM CEST, Dominik Csapak wrote:
>> By saving the state in the browsers local storage.
>>
>> It also fixes an issue where menus that were collapsed by default wouldn't open
>> on the first click.
>>
>> Note that for the pdm patches, pwt must be bumped and the new version must be
>> recorded in Cargo.toml.
>>
>>
>> proxmox-yew-widget-toolki:
>>
>> Dominik Csapak (2):
>>    widget: navigation drawer: fix first open for default collapsed menus
>>    widget: navigation drawer: allow persisting the expanded state
>>
>>   src/widget/nav/navigation_drawer.rs | 138 +++++++++++++++++++++++-----
>>   1 file changed, 115 insertions(+), 23 deletions(-)
>>
>>
>> proxmox-datacenter-manager:
>>
>> Dominik Csapak (1):
>>    ui: main menu: make expanded/collapsed state persistent
>>
>>   ui/src/main_menu.rs | 1 +
>>   1 file changed, 1 insertion(+)
>>
>>
>> Summary over all repositories:
>>    2 files changed, 116 insertions(+), 23 deletions(-)
> 
> 
> LGTM in general, works fine and the code seems good too.
> 
> One thought, looking at the saved state in the web inspector in Firefox:
> Would it maybe make sense for future extensions to slightly update the
> serialized format from
> 
> ["sdn","administration"]
> 
> to something like:
> 
> { collapsed: ["sdn", "administration"]}
> 
> That would make it much easier to add other keys as well in the future,
> if we need to store additional state.

it's actually not collapsed, but changed from the default
(the main menu in pdm just happens to default to all expanded)

so it would be { "changed": [...] }

would that be ok?

we could of course do this in the future and interpret
an array as just the changed list and migrate automatically.

in practice this would look like (rough pseude code):

let try1: Result<NewStateFormat, _> = input.parse();
match try1 {
    Ok(state) => { /* return the state */ }
    Err(err) => {
        let legacy: Result<OldStateFormat, _> = input.parse();
        // either take legacy and convert to new state
        // or return original error 'err'
    }
}

> 
> Not a blocker from my side though:
> 
> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
> Tested-by: Lukas Wagner <l.wagner@proxmox.com>