From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5D47D1FF09B for ; Mon, 31 Aug 2026 15:02:34 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 07C11213E1; Mon, 31 Aug 2026 15:02:34 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 31 Aug 2026 15:02:30 +0200 Message-Id: From: "Lukas Wagner" To: "Dominik Csapak" , Subject: Re: [PATCH datacenter-manager/yew-widget-toolkit 0/3] ui: persist the main menus expanded state X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260820081803.991511-1-d.csapak@proxmox.com> In-Reply-To: <20260820081803.991511-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788181337449 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.554 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: X6OONJNVU7OUDDXKXGELEUEGZSARSQTT X-Message-ID-Hash: X6OONJNVU7OUDDXKXGELEUEGZSARSQTT X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Aug 20, 2026 at 10:17 AM CEST, Dominik Csapak wrote: > By saving the state in the browsers local storage. > > It also fixes an issue where menus that were collapsed by default wouldn'= t open > on the first click. > > Note that for the pdm patches, pwt must be bumped and the new version mus= t be > recorded in Cargo.toml. > > > proxmox-yew-widget-toolki: > > Dominik Csapak (2): > widget: navigation drawer: fix first open for default collapsed menus > widget: navigation drawer: allow persisting the expanded state > > src/widget/nav/navigation_drawer.rs | 138 +++++++++++++++++++++++----- > 1 file changed, 115 insertions(+), 23 deletions(-) > > > proxmox-datacenter-manager: > > Dominik Csapak (1): > ui: main menu: make expanded/collapsed state persistent > > ui/src/main_menu.rs | 1 + > 1 file changed, 1 insertion(+) > > > Summary over all repositories: > 2 files changed, 116 insertions(+), 23 deletions(-) LGTM in general, works fine and the code seems good too. One thought, looking at the saved state in the web inspector in Firefox: Would it maybe make sense for future extensions to slightly update the serialized format from=20 ["sdn","administration"] to something like: { collapsed: ["sdn", "administration"]} That would make it much easier to add other keys as well in the future, if we need to store additional state. Not a blocker from my side though: Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner