From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Christoph Heiss" <c.heiss@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager 15/16] ui: auto-installer: wizard: add checkbox to add target as new remote
Date: Tue, 04 Aug 2026 13:39:26 +0200 [thread overview]
Message-ID: <DKG4PKESZ4S1.36E3LHLW44CPK@proxmox.com> (raw)
In-Reply-To: <20260731143910.936881-16-c.heiss@proxmox.com>
On Fri Jul 31, 2026 at 4:35 PM CEST, Christoph Heiss wrote:
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> .../remotes/auto_installer/prepared_answer_add_wizard.rs | 1 +
> ui/src/remotes/auto_installer/prepared_answer_form.rs | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> index 03d78be8..a4ea66e0 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> @@ -81,6 +81,7 @@ impl AddAnswerWizardProperties {
> // post hook
> post_hook_base_url: pdm_origin(),
> post_hook_cert_fp: fingerprint,
> + post_hook_add_as_remote: true,
> // templating
> template_counters,
> // subscription
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> index 6ee4b15a..e6eace8f 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> @@ -985,6 +985,13 @@ pub fn render_auth_form(
> .tip(tr!("Optional certificate fingerprint"))
> .value(config.post_hook_cert_fp.clone()),
> )
> + .with_field(
> + tr!("Provision As New Remote"),
> + Checkbox::new()
> + .name("post-hook-add-as-remote")
> + .tip(tr!("Only available for Virtual Environment and Backup Server. Add the target host as new remote to this Datacenter Manager instance."))
In other words, available for all products PDM currently supports? I
think you could leave out the tooltip, this might actually confuse
users.
> + .default(config.post_hook_add_as_remote),
> + )
> .with_large_custom_child(
> Container::from_tag("p")
> .key("post-hook-hint")
next prev parent reply other threads:[~2026-08-04 11:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 14:35 [PATCH proxmox/installer/datacenter-manager 00/16] auto-installer: add installed target systems as new remotes Christoph Heiss
2026-07-31 14:35 ` [PATCH proxmox 01/16] installer-types: drop unnecessary clippy attribute Christoph Heiss
2026-07-31 14:35 ` [PATCH proxmox 02/16] installer-types: post-hook: factor schema version into proper struct Christoph Heiss
2026-08-04 11:39 ` Lukas Wagner
2026-07-31 14:35 ` [PATCH proxmox 03/16] installer-types: post-hook: allow additional properties on api schema Christoph Heiss
2026-07-31 14:35 ` [PATCH proxmox 04/16] installer-types: post-hook: add api-token and cert-fingerprint options Christoph Heiss
2026-07-31 14:35 ` [PATCH proxmox 05/16] installer-types: systeminfo: add check for API token creation capability Christoph Heiss
2026-08-04 11:39 ` Lukas Wagner
2026-07-31 14:35 ` [PATCH installer 06/16] chroot: print full error if bind-mounting fails Christoph Heiss
2026-07-31 14:35 ` [PATCH installer 07/16] post-hook: re-use low-level config retrieval from proxmox-chroot Christoph Heiss
2026-07-31 14:35 ` [PATCH installer 08/16] post-hook: generate and retrieve node certificate fingerprint Christoph Heiss
2026-08-04 11:39 ` Lukas Wagner
2026-07-31 14:35 ` [PATCH installer 09/16] post-hook: support creating API token if requested in answer file Christoph Heiss
2026-08-04 11:39 ` Lukas Wagner
2026-07-31 14:35 ` [PATCH installer 10/16] auto: enforce https for post hook when generating an API token Christoph Heiss
2026-07-31 14:35 ` [PATCH installer 11/16] assistant: validate-answer: also verify post-hook settings if set Christoph Heiss
2026-07-31 14:35 ` [PATCH datacenter-manager 12/16] ui: auto-installer: spell out Proxmox Datacenter Manager Christoph Heiss
2026-07-31 14:35 ` [PATCH datacenter-manager 13/16] config: auto-install: add optional `post-hook-add-as-remote` field Christoph Heiss
2026-07-31 14:35 ` [PATCH datacenter-manager 14/16] api: auto-installer: add option for adding new remotes to PDM Christoph Heiss
2026-07-31 14:35 ` [PATCH datacenter-manager 15/16] ui: auto-installer: wizard: add checkbox to add target as new remote Christoph Heiss
2026-08-04 11:39 ` Lukas Wagner [this message]
2026-07-31 14:35 ` [PATCH datacenter-manager 16/16] docs: auto-installer: document adding targets as remotes afterwards Christoph Heiss
2026-07-31 22:05 ` Unsuscribe Pablo Méndez Segura
2026-08-04 11:39 ` [PATCH datacenter-manager 16/16] docs: auto-installer: document adding targets as remotes afterwards Lukas Wagner
2026-08-04 11:38 ` [PATCH proxmox/installer/datacenter-manager 00/16] auto-installer: add installed target systems as new remotes Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKG4PKESZ4S1.36E3LHLW44CPK@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox