Re: [PATCH proxmox 02/16] installer-types: post-hook: factor schema version into proper struct

["Lukas Wagner" <l.wagner@proxmox.com>]

On Fri Jul 31, 2026 at 4:35 PM CEST, Christoph Heiss wrote:
> This simplifies first and foremost version comparison on consumer sites,
> making the schema version actually useful.
>
> No actual API changes, the version is still serialized to/deserialized
> from a plain X.Y string.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  proxmox-installer-types/src/answer.rs    | 68 +++++++++++++++++++++---
>  proxmox-installer-types/src/lib.rs       | 18 +++++++
>  proxmox-installer-types/src/post_hook.rs | 13 +++--
>  3 files changed, 90 insertions(+), 9 deletions(-)
>
> diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs
> index 266d6a27..68cac026 100644
> --- a/proxmox-installer-types/src/answer.rs
> +++ b/proxmox-installer-types/src/answer.rs
> @@ -9,6 +9,7 @@
>  use anyhow::{Result, anyhow, bail};
>  use serde::{Deserialize, Serialize};
>  use std::{
> +    cmp::Ordering,
>      collections::{BTreeMap, HashMap},
>      fmt::{self, Display},
>      str::FromStr,
> @@ -63,6 +64,38 @@ pub const SUBSCRIPTION_KEY_SCHEMA: proxmox_schema::Schema =
>          .max_length(32)
>          .schema();
>  
> +/// Represents a (major, minor) schema version tuple.
> +#[derive(Copy, Clone, Debug, PartialEq, Eq)]
> +pub struct SchemaVersion(pub u32, pub u32);
> +
> +impl PartialOrd for SchemaVersion {
> +    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
> +        match (self.0.cmp(&other.0), self.1.cmp(&other.1)) {
> +            (Ordering::Equal, ord) => Some(ord),
> +            (ord, _) => Some(ord),
> +        }
> +    }

You could use Ordering::then to simplify this, e.g.

Some(self.0.cmp(&other.0).then(self.1.cmp(&other.1)))

https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then

You could also use it in the partial_cmp implementation of
`ProductVersion`, spotted the same there as well.