Re: [PATCH installer 09/16] post-hook: support creating API token if requested in answer file

["Lukas Wagner" <l.wagner@proxmox.com>]

On Fri Jul 31, 2026 at 4:35 PM CEST, Christoph Heiss wrote:
> diff --git a/proxmox-post-hook/src/main.rs b/proxmox-post-hook/src/main.rs
> index 760ab53..f7a41c9 100644
> --- a/proxmox-post-hook/src/main.rs
> +++ b/proxmox-post-hook/src/main.rs
> @@ -49,8 +49,8 @@ mod detail {
>              AutoInstallerConfig, FqdnConfig, FqdnFromDhcpConfig, FqdnSourceMode, SchemaVersion,
>          },
>          post_hook::{
> -            BootInfo, CpuInfo, DiskInfo, KernelVersionInformation, NetworkInterfaceInfo,
> -            PostHookInfo, PostHookInfoSchema, ProductInfo, SchemaVersion, SshPublicHostKeys,
> +            BootInfo, CpuInfo, CreatedApiToken, DiskInfo, KernelVersionInformation,
> +            NetworkInterfaceInfo, PostHookInfo, PostHookInfoSchema, ProductInfo, SshPublicHostKeys,
>          },
>      };
>  
> @@ -148,6 +148,24 @@ mod detail {
>              None
>          };
>  
> +        let api_token = if let Some(name) = answer
> +            .post_installation_webhook
> +            .as_ref()
> +            .and_then(|p| p.api_token_name.as_ref())
> +            && schema_1_3_supported
> +            && setup_info.config.product.supports_api_token_creation()
> +        {
> +            match create_api_token(name, target_path, setup_info.config.product, &run_cmd) {
> +                Ok(token) => Some(token),
> +                Err(err) => {
> +                    eprintln!("could not create API token: {err:#}");
> +                    None
> +                }
> +            }

You could do a 

    create_api_token(name, target_path, setup_info.config.product, &run_cmd)
	.inspect_err(|err| eprintln!("could not create API token: {err:#}"))
	.ok()

here, seems quite a bit shorter

> +        } else {
> +            None
> +        };
> +