Re: [PATCH installer 08/16] post-hook: generate and retrieve node certificate fingerprint

["Lukas Wagner" <l.wagner@proxmox.com>]

On Fri Jul 31, 2026 at 4:35 PM CEST, Christoph Heiss wrote:
>  
> +    /// First creates the initial node certificate, then computes the fingerprint from the freshly
> +    /// initialized proxy certificate.
> +    fn gather_node_cert_fingerprint(

I think since this function always generates the certificate, the name
gather_nod_cert_fingerprint is not ideal. Maybe call it
`generate_node_certificate`? A function with that name returning a
fingerprint of the generated cert seems plausible to me.

> +        target_path: &str,
> +        product: ProxmoxProduct,
> +        open_file: &dyn Fn(&str) -> Result<File>,
> +        run_cmd: &dyn Fn(&[&str]) -> Result<String>,
> +    ) -> Result<Option<String>> {
> +        println!("Generating node certificates ..");
> +
> +        match product {
> +            ProxmoxProduct::Pve => with_pmxcfs(target_path, |_| {
> +                run_cmd(&["pvecm", "updatecerts"])
> +                    .context("failed to generate node certificates")?;
> +                retrieve_cert_fingerprint(open_file("/etc/pve/local/pve-ssl.pem")?).map(Some)
> +            }),
> +            ProxmoxProduct::Pbs => {
> +                run_cmd(&["proxmox-backup-manager", "cert", "update"])
> +                    .context("failed to generate node certificates")?;
> +                retrieve_cert_fingerprint(open_file("/etc/proxmox-backup/proxy.pem")?).map(Some)
> +            }
> +            ProxmoxProduct::Pmg => {
> +                run_cmd(&["pmgconfig", "apicert"])
> +                    .context("failed to generate node certificates")?;
> +                retrieve_cert_fingerprint(open_file("/etc/pmg/pmg-api.pem")?).map(Some)
> +            }
> +            _ => Ok(None),
> +        }
> +    }
> +