* [PATCH datacenter-manager 1/2] ui: ceph: fix vertical alignment of usage meter @ 2026-05-26 10:27 Dominik Csapak 2026-05-26 10:27 ` [PATCH datacenter-manager 2/2] ui: move global guest panel in the top level navigation Dominik Csapak 2026-05-26 13:47 ` applied: [PATCH datacenter-manager 1/2] ui: ceph: fix vertical alignment of usage meter Thomas Lamprecht 0 siblings, 2 replies; 5+ messages in thread From: Dominik Csapak @ 2026-05-26 10:27 UTC (permalink / raw) To: pdm-devel the usage meter here meddles with the baseline, so we must use 'middle' instead of the default 'baseline'. Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> --- ui/src/ceph/clusters.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/src/ceph/clusters.rs b/ui/src/ceph/clusters.rs index 4ee8a3fd..5929dd8d 100644 --- a/ui/src/ceph/clusters.rs +++ b/ui/src/ceph/clusters.rs @@ -317,6 +317,7 @@ fn columns() -> Rc<Vec<DataTableHeader<CephClusterListEntry>>> { .into(), DataTableColumn::new(tr!("Usage")) .width("minmax(100px,3fr)") + .vertical_align("middle") .render( |item: &CephClusterListEntry| match (item.bytes_used, item.bytes_total) { (Some(used), Some(total)) if total > 0 => usage_meter(used, total), -- 2.47.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH datacenter-manager 2/2] ui: move global guest panel in the top level navigation 2026-05-26 10:27 [PATCH datacenter-manager 1/2] ui: ceph: fix vertical alignment of usage meter Dominik Csapak @ 2026-05-26 10:27 ` Dominik Csapak 2026-05-26 11:04 ` Lukas Wagner 2026-05-26 13:47 ` applied: [PATCH datacenter-manager 1/2] ui: ceph: fix vertical alignment of usage meter Thomas Lamprecht 1 sibling, 1 reply; 5+ messages in thread From: Dominik Csapak @ 2026-05-26 10:27 UTC (permalink / raw) To: pdm-devel It's a very useful view to have so don't hide it in the remotes tab panel. Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> --- ui/src/main_menu.rs | 10 ++++++++++ ui/src/remotes/mod.rs | 9 --------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/ui/src/main_menu.rs b/ui/src/main_menu.rs index a8af7502..d2c56e0b 100644 --- a/ui/src/main_menu.rs +++ b/ui/src/main_menu.rs @@ -19,6 +19,7 @@ use crate::configuration::subscription_panel::SubscriptionPanel; use crate::configuration::subscription_registry::SubscriptionRegistryProps; use crate::configuration::views::ViewGrid; use crate::dashboard::view::View; +use crate::guests::GuestPanel; use crate::remotes::RemotesPanel; use crate::sdn::evpn::EvpnPanel; use crate::sdn::ZoneTree; @@ -359,6 +360,15 @@ impl Component for PdmMainMenu { |_| CephView::new().into(), ); + register_view( + &mut menu, + &mut content, + tr!("Guests"), + "guests", + Some("fa fa-desktop"), + |_| GuestPanel::new().into(), + ); + let mut remote_submenu = Menu::new(); for remote in props.remote_list.iter() { diff --git a/ui/src/remotes/mod.rs b/ui/src/remotes/mod.rs index a8edab23..ddc8365a 100644 --- a/ui/src/remotes/mod.rs +++ b/ui/src/remotes/mod.rs @@ -40,8 +40,6 @@ use auto_installer::AutoInstallerPanel; use yew::{function_component, Html}; -use crate::guests::GuestPanel; - use pwt::prelude::*; use pwt::{ props::StorageLocation, @@ -63,13 +61,6 @@ pub fn system_configuration() -> Html { .icon_class("fa fa-cogs"), |_| RemoteConfigPanel::new().into(), ) - .with_item_builder( - TabBarItem::new() - .key("guests") - .label(tr!("Guests")) - .icon_class("fa fa-desktop"), - |_| GuestPanel::new().into(), - ) .with_item_builder( TabBarItem::new() .key("tasks") -- 2.47.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH datacenter-manager 2/2] ui: move global guest panel in the top level navigation 2026-05-26 10:27 ` [PATCH datacenter-manager 2/2] ui: move global guest panel in the top level navigation Dominik Csapak @ 2026-05-26 11:04 ` Lukas Wagner 2026-05-26 12:07 ` Thomas Lamprecht 0 siblings, 1 reply; 5+ messages in thread From: Lukas Wagner @ 2026-05-26 11:04 UTC (permalink / raw) To: Dominik Csapak, pdm-devel On Tue May 26, 2026 at 12:27 PM CEST, Dominik Csapak wrote: > It's a very useful view to have so don't hide it in the remotes tab > panel. > Makes sense to me, so Acked-by: Lukas Wagner <l.wagner@proxmox.com> On a tangent, at some point we probably have to rethink the tabs under "Remotes" anyways, I think they have the potential to become quite unwieldily once we add a couple more tabs there. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH datacenter-manager 2/2] ui: move global guest panel in the top level navigation 2026-05-26 11:04 ` Lukas Wagner @ 2026-05-26 12:07 ` Thomas Lamprecht 0 siblings, 0 replies; 5+ messages in thread From: Thomas Lamprecht @ 2026-05-26 12:07 UTC (permalink / raw) To: Lukas Wagner, Dominik Csapak, pdm-devel Am 26.05.26 um 13:04 schrieb Lukas Wagner: > On Tue May 26, 2026 at 12:27 PM CEST, Dominik Csapak wrote: >> It's a very useful view to have so don't hide it in the remotes tab >> panel. >> > > Makes sense to me, so > > Acked-by: Lukas Wagner <l.wagner@proxmox.com> > Just some context for posterity: I asked Dominik what he thought about this off-list because on an initial prototype I placed it there, but then moved it in the Remotes tab given that it couldn't do that much back then, it doesn't can to much more (snapshots got added since then), but that's not the whole point here - it simply is one of the most important resources PDM manages, so a "first class" navigation entry is probably fine; thx for both your opinions here. > On a tangent, at some point we probably have to rethink the tabs under > "Remotes" anyways, I think they have the potential to become quite > unwieldily once we add a couple more tabs there. Yeah, I agree, the navigation story should be reevaluated in the midterm. ^ permalink raw reply [flat|nested] 5+ messages in thread
* applied: [PATCH datacenter-manager 1/2] ui: ceph: fix vertical alignment of usage meter 2026-05-26 10:27 [PATCH datacenter-manager 1/2] ui: ceph: fix vertical alignment of usage meter Dominik Csapak 2026-05-26 10:27 ` [PATCH datacenter-manager 2/2] ui: move global guest panel in the top level navigation Dominik Csapak @ 2026-05-26 13:47 ` Thomas Lamprecht 1 sibling, 0 replies; 5+ messages in thread From: Thomas Lamprecht @ 2026-05-26 13:47 UTC (permalink / raw) To: pdm-devel, Dominik Csapak On Tue, 26 May 2026 12:27:50 +0200, Dominik Csapak wrote: > the usage meter here meddles with the baseline, so we must use 'middle' > instead of the default 'baseline'. Applied, thanks! [1/2] ui: ceph: fix vertical alignment of usage meter commit: 85004611d29a1391b64569369aa203ef671d3e52 [2/2] ui: move global guest panel in the top level navigation commit: 381478fe9e4f406972b50466c83a5bf22b9f7eb3 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-05-26 13:48 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-05-26 10:27 [PATCH datacenter-manager 1/2] ui: ceph: fix vertical alignment of usage meter Dominik Csapak 2026-05-26 10:27 ` [PATCH datacenter-manager 2/2] ui: move global guest panel in the top level navigation Dominik Csapak 2026-05-26 11:04 ` Lukas Wagner 2026-05-26 12:07 ` Thomas Lamprecht 2026-05-26 13:47 ` applied: [PATCH datacenter-manager 1/2] ui: ceph: fix vertical alignment of usage meter Thomas Lamprecht
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox