Re: [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Fri, Jul 24, 2026 at 12:00:01AM +0200, Thomas Lamprecht wrote:
> Am 23.07.26 um 13:45 schrieb Arthur Bied-Charreton:
> > The calendar matcher examples showed weekday ranges as start-end. The
> > correct syntax is start..end - these example configs do not parse.
> > 
> > Update the examples to the correct a..b range syntax.
> > 
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> > ---
> >  docs/notifications.rst | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/docs/notifications.rst b/docs/notifications.rst
> > index 440c700a4..7d6517dd7 100644
> > --- a/docs/notifications.rst
> > +++ b/docs/notifications.rst
> > @@ -217,8 +217,8 @@ Examples:
> >  
> >  * ``match-calendar 8-12``
> 
> Shouldn't above also change? or is that hours? These examples here
> would IMO do very well with actually explaining what each means, it's
> not exactly clear as it stands. A reference to the calendar events
> appendix at _calendar-event-scheduling would already help a lot and
> might we warranted either way, if this here is really using that format.

those are hours, our daytime ranges only accept '-' as delimiter, '..'
fails to parse. from a quick look at the proxmox-time code, it should be
quite easy to align this behavior with systemd, i.e. to allow both '-'
and '..' for weekday ranges and only '-' for daytime ranges. what do you
think?

you're right that these docs could use a touch-up, will send a v2 after
coordinating with Lukas W. 

> >  * ``match-calendar 8:00-15:30``
> > -* ``match-calendar mon-fri 9:00-17:00``
> 
> FWIW; systemd-analyze calendar "mon-fri" works, but it does normalize
> it to mon..fri
> 
thanks for the context!
> > -* ``match-calendar sun,tue-wed,fri 9-17``
> > +* ``match-calendar mon..fri 9:00-17:00``
> > +* ``match-calendar sun,tue..wed,fri 9-17``
> >  
> >  Field Matching Rules
> >  ^^^^^^^^^^^^^^^^^^^^
> > @@ -417,4 +417,3 @@ Counter Threshold    Description and Usage
> >  ``s3-download``      Amount of bytes downloaded from the S3 endpoint,
> >                       independent of request method.
> >  ==================== ==========================================================
> > -
> 
> extra line removal, but fine as clean-up to tag along I guess.
did not notice that, sorry for the noise