From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 396041FF0E6 for ; Fri, 24 Jul 2026 07:22:34 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6F72B21468; Fri, 24 Jul 2026 07:22:33 +0200 (CEST) Date: Fri, 24 Jul 2026 07:21:58 +0200 From: Arthur Bied-Charreton To: Thomas Lamprecht Subject: Re: [PATCH proxmox-backup] docs: notifications: fix broken calendar match examples Message-ID: References: <20260723114548.319543-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784870488992 X-SPAM-LEVEL: Spam detection results: 1 AWL 1.138 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EWAK3AOFGHPXUHRH7DO53RNR5VHNJYDK X-Message-ID-Hash: EWAK3AOFGHPXUHRH7DO53RNR5VHNJYDK X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Jul 24, 2026 at 12:00:01AM +0200, Thomas Lamprecht wrote: > Am 23.07.26 um 13:45 schrieb Arthur Bied-Charreton: > > The calendar matcher examples showed weekday ranges as start-end. The > > correct syntax is start..end - these example configs do not parse. > > > > Update the examples to the correct a..b range syntax. > > > > Signed-off-by: Arthur Bied-Charreton > > --- > > docs/notifications.rst | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/docs/notifications.rst b/docs/notifications.rst > > index 440c700a4..7d6517dd7 100644 > > --- a/docs/notifications.rst > > +++ b/docs/notifications.rst > > @@ -217,8 +217,8 @@ Examples: > > > > * ``match-calendar 8-12`` > > Shouldn't above also change? or is that hours? These examples here > would IMO do very well with actually explaining what each means, it's > not exactly clear as it stands. A reference to the calendar events > appendix at _calendar-event-scheduling would already help a lot and > might we warranted either way, if this here is really using that format. those are hours, our daytime ranges only accept '-' as delimiter, '..' fails to parse. from a quick look at the proxmox-time code, it should be quite easy to align this behavior with systemd, i.e. to allow both '-' and '..' for weekday ranges and only '-' for daytime ranges. what do you think? you're right that these docs could use a touch-up, will send a v2 after coordinating with Lukas W. > > * ``match-calendar 8:00-15:30`` > > -* ``match-calendar mon-fri 9:00-17:00`` > > FWIW; systemd-analyze calendar "mon-fri" works, but it does normalize > it to mon..fri > thanks for the context! > > -* ``match-calendar sun,tue-wed,fri 9-17`` > > +* ``match-calendar mon..fri 9:00-17:00`` > > +* ``match-calendar sun,tue..wed,fri 9-17`` > > > > Field Matching Rules > > ^^^^^^^^^^^^^^^^^^^^ > > @@ -417,4 +417,3 @@ Counter Threshold Description and Usage > > ``s3-download`` Amount of bytes downloaded from the S3 endpoint, > > independent of request method. > > ==================== ========================================================== > > - > > extra line removal, but fine as clean-up to tag along I guess. did not notice that, sorry for the noise