Re: [PATCH v1 proxmox-backup 2/3] client: pxar: consistently ignore vanished files and warn about them

[Robert Obkircher <r.obkircher@proxmox.com>]

On 08.05.26 15:24, Christian Ebner wrote:
> On 5/8/26 1:38 PM, Robert Obkircher wrote:
>>
>> On 08.05.26 11:36, Christian Ebner wrote:
>>> On 5/7/26 5:48 PM, Robert Obkircher wrote:
>
> [..]
>
>>>>>
>>>> How? This is the error path that converts the Errno to an anyhow
>>>> error. It doesn't call the method from that trait.
>>>
>>> diff --git a/pbs-client/src/pxar/create.rs
>>> b/pbs-client/src/pxar/create.rs
>>> index c101415c1..e1e4eea3b 100644
>>> --- a/pbs-client/src/pxar/create.rs
>>> +++ b/pbs-client/src/pxar/create.rs
>>> @@ -720,7 +720,8 @@ impl Archiver {
>>>                       continue;
>>>                   }
>>>                   Err(err) => {
>>> -                    return
>>> Err(Error::from(err).context(format!("stat failed on
>>> {full_path:?}")))
>>> +                    return Err(Error::from(err))
>>> +                        .with_context(|| format!("stat failed on
>>> {full_path:?}"))
>>>                   }
>>>               };
>>>
>>> This should do, unless I'm overlooking something?
>>
>> If we inline <Result as Context>::with_context then your version it
>> results in
>>
>> match Err(Error::from(err)) {
>>      Ok(ok) => Ok(ok),
>>      Err(error) => Err(error.ext_context(context())),
>> }
>>
>> which is not lazy. The original code had both versions and I chose the
>> more explicit one.
>
> Right (should have checked the implementation details first).
>
> In that case could you include a patch to cleanup the (one) other
> implicit context creation? 

Which one? I don't see another one