From: Robert Obkircher <r.obkircher@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v1 proxmox-backup 3/3] client: pxar: skip files on fstatat permission errors
Date: Wed, 6 May 2026 13:49:26 +0200 [thread overview]
Message-ID: <20260506115016.171006-4-r.obkircher@proxmox.com> (raw)
In-Reply-To: <20260506115016.171006-1-r.obkircher@proxmox.com>
Log a warning instead of aborting the entire backup if fstatat returns
a permission error. This is preferable when running backups without
full knowledge or control over the contents [1]. It is also more
consistent with how we treat EACCES when opening files.
Note that it was already possible to explicitly exclude such files[2].
[1] https://forum.proxmox.com/threads/bug-with-fuse-mounts.182315/
[2] https://bugzilla.proxmox.com/show_bug.cgi?id=4380
Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
---
pbs-client/src/pxar/create.rs | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
index 47cbf50a8..c101415c1 100644
--- a/pbs-client/src/pxar/create.rs
+++ b/pbs-client/src/pxar/create.rs
@@ -710,6 +710,11 @@ impl Archiver {
warn!("warning: file vanished while reading directory: {full_path:?}");
continue;
}
+ Err(Errno::EACCES) => {
+ // may happen for fuse mountpoints without allow_other or allow_root
+ warn!("failed to stat file: {full_path:?}: access denied");
+ continue;
+ }
Err(Errno::ESTALE) => {
self.report_stale_file_handle(Some(&full_path));
continue;
--
2.47.3
next prev parent reply other threads:[~2026-05-06 11:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 11:49 [PATCH v1 proxmox-backup 0/3] improve fstatat error handling Robert Obkircher
2026-05-06 11:49 ` [PATCH v1 proxmox-backup 1/3] client: pxar: improve variable names Robert Obkircher
2026-05-07 8:38 ` Christian Ebner
2026-05-06 11:49 ` [PATCH v1 proxmox-backup 2/3] client: pxar: consistently ignore vanished files and warn about them Robert Obkircher
2026-05-07 8:38 ` Christian Ebner
2026-05-07 15:50 ` Robert Obkircher
2026-05-08 9:38 ` Christian Ebner
2026-05-08 11:40 ` Robert Obkircher
2026-05-08 13:26 ` Christian Ebner
2026-05-08 14:03 ` Robert Obkircher
2026-05-08 14:12 ` Christian Ebner
2026-05-06 11:49 ` Robert Obkircher [this message]
2026-05-07 8:42 ` [PATCH v1 proxmox-backup 3/3] client: pxar: skip files on fstatat permission errors Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506115016.171006-4-r.obkircher@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox