From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BDFAE1FF14F for ; Fri, 08 May 2026 16:04:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BD47A1AEFD; Fri, 8 May 2026 16:04:16 +0200 (CEST) Message-ID: <2d49c10e-10ec-4160-9405-c8fda9285c9c@proxmox.com> Date: Fri, 8 May 2026 16:03:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 proxmox-backup 2/3] client: pxar: consistently ignore vanished files and warn about them To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260506115016.171006-1-r.obkircher@proxmox.com> <20260506115016.171006-3-r.obkircher@proxmox.com> <0dc3289a-f214-4d3b-8138-47ff79a61878@proxmox.com> <0def9d7e-135a-4db4-a7f9-56d512b1c15f@proxmox.com> <4d21540f-f92b-48e1-a586-81a2d4412b05@proxmox.com> <89b54e4c-1f39-43d5-b3c2-6d03a6170c3d@proxmox.com> <8ef30f56-0786-4d46-b7be-e56d71a92f27@proxmox.com> Content-Language: en-US, de-AT From: Robert Obkircher In-Reply-To: <8ef30f56-0786-4d46-b7be-e56d71a92f27@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778248911564 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [create.rs] Message-ID-Hash: HWB7XHVEIJ5FVYNAFZ53YJM33M5LBPW4 X-Message-ID-Hash: HWB7XHVEIJ5FVYNAFZ53YJM33M5LBPW4 X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 08.05.26 15:24, Christian Ebner wrote: > On 5/8/26 1:38 PM, Robert Obkircher wrote: >> >> On 08.05.26 11:36, Christian Ebner wrote: >>> On 5/7/26 5:48 PM, Robert Obkircher wrote: > > [..] > >>>>> >>>> How? This is the error path that converts the Errno to an anyhow >>>> error. It doesn't call the method from that trait. >>> >>> diff --git a/pbs-client/src/pxar/create.rs >>> b/pbs-client/src/pxar/create.rs >>> index c101415c1..e1e4eea3b 100644 >>> --- a/pbs-client/src/pxar/create.rs >>> +++ b/pbs-client/src/pxar/create.rs >>> @@ -720,7 +720,8 @@ impl Archiver { >>>                       continue; >>>                   } >>>                   Err(err) => { >>> -                    return >>> Err(Error::from(err).context(format!("stat failed on >>> {full_path:?}"))) >>> +                    return Err(Error::from(err)) >>> +                        .with_context(|| format!("stat failed on >>> {full_path:?}")) >>>                   } >>>               }; >>> >>> This should do, unless I'm overlooking something? >> >> If we inline ::with_context then your version it >> results in >> >> match Err(Error::from(err)) { >>      Ok(ok) => Ok(ok), >>      Err(error) => Err(error.ext_context(context())), >> } >> >> which is not lazy. The original code had both versions and I chose the >> more explicit one. > > Right (should have checked the implementation details first). > > In that case could you include a patch to cleanup the (one) other > implicit context creation?  Which one? I don't see another one