public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox] fix #8127: notify: matcher: fix description of match-calendar
@ 2026-11-07 22:35 Lucas Barros
  0 siblings, 0 replies; only message in thread
From: Lucas Barros @ 2026-11-07 22:35 UTC (permalink / raw)
  To: pbs-devel

The doc comment of the 'match-calendar' property was copied from
'match-severity', so the API schema, and with it the CLI help and the
man page of 'proxmox-backup-manager notification matcher create' and
'update', describes it as a list of matched severity levels. The
option matches the timestamp of a notification against calendar
entries, though.

Use a description that fits what the option does.

Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
---

The 'match-severity' doc comment right above it is correct and left as
is. The items description of the same property in the api macro
("Time stamps to match") is left alone as well.

Doc comment change only. I did not build the crate locally (no Rust
toolchain on this machine).

This patch was prepared with the help of an LLM based coding assistant; I
reviewed the change and ran the tests mentioned above myself.

 proxmox-notify/src/matcher/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-notify/src/matcher/mod.rs b/proxmox-notify/src/matcher/mod.rs
index 59be88f..af87a4e 100644
--- a/proxmox-notify/src/matcher/mod.rs
+++ b/proxmox-notify/src/matcher/mod.rs
@@ -93,7 +93,7 @@ pub struct MatcherConfig {
     #[cfg(feature = "legacy-matchers")]
     pub match_severity: Vec<severity::InlineSeverityMatcher>,
 
-    /// List of matched severity levels.
+    /// List of matched calendar entries.
     #[serde(default, skip_serializing_if = "Vec::is_empty")]
     #[updater(serde(skip_serializing_if = "Option::is_none"))]
     #[cfg(feature = "legacy-matchers")]
-- 
2.50.1 (Apple Git-155)




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-07 22:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-07 22:35 [PATCH proxmox] fix #8127: notify: matcher: fix description of match-calendar Lucas Barros

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal