public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lucas Barros <lucasbarros.kam@gmail.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox] fix #8127: notify: matcher: fix description of match-calendar
Date: Sat,  7 Nov 2026 19:35:22 -0300	[thread overview]
Message-ID: <20261107223522.23169-1-lucasbarros.kam@gmail.com> (raw)

The doc comment of the 'match-calendar' property was copied from
'match-severity', so the API schema, and with it the CLI help and the
man page of 'proxmox-backup-manager notification matcher create' and
'update', describes it as a list of matched severity levels. The
option matches the timestamp of a notification against calendar
entries, though.

Use a description that fits what the option does.

Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
---

The 'match-severity' doc comment right above it is correct and left as
is. The items description of the same property in the api macro
("Time stamps to match") is left alone as well.

Doc comment change only. I did not build the crate locally (no Rust
toolchain on this machine).

This patch was prepared with the help of an LLM based coding assistant; I
reviewed the change and ran the tests mentioned above myself.

 proxmox-notify/src/matcher/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-notify/src/matcher/mod.rs b/proxmox-notify/src/matcher/mod.rs
index 59be88f..af87a4e 100644
--- a/proxmox-notify/src/matcher/mod.rs
+++ b/proxmox-notify/src/matcher/mod.rs
@@ -93,7 +93,7 @@ pub struct MatcherConfig {
     #[cfg(feature = "legacy-matchers")]
     pub match_severity: Vec<severity::InlineSeverityMatcher>,
 
-    /// List of matched severity levels.
+    /// List of matched calendar entries.
     #[serde(default, skip_serializing_if = "Vec::is_empty")]
     #[updater(serde(skip_serializing_if = "Option::is_none"))]
     #[cfg(feature = "legacy-matchers")]
-- 
2.50.1 (Apple Git-155)




                 reply	other threads:[~2026-11-07 22:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107223522.23169-1-lucasbarros.kam@gmail.com \
    --to=lucasbarros.kam@gmail.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal