public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 09/14] fix #7904: Improve visibility of disabled GC on the overview page
Date: Wed, 30 Sep 2026 17:18:07 +0200	[thread overview]
Message-ID: <20260930152131.317493-10-j.theisen@proxmox.com> (raw)
In-Reply-To: <20260930152131.317493-1-j.theisen@proxmox.com>

This commit adds additional logic to prominently display if
a GC job was disabled on the GC overview page.

If the GC is disabled the text "Disabled" is shown instead of
the schedule which is still present in the config file.

For backwords compatibility if no schedule is defined the fallback
is still None.

Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 www/Utils.js         | 10 ++++++++++
 www/config/GCView.js |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/www/Utils.js b/www/Utils.js
index d6bfd459e..8abbeee57 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -335,6 +335,16 @@ Ext.define('PBS.Utils', {
         );
     },
 
+    render_schedule: function (val, metadat, record) {
+        if(record.data.enable === false) {
+            return gettext('Disabled');
+        }
+        if(val) {
+            return val;
+        }
+        return Proxmox.Utils.NoneText;
+    },
+
     get_help_tool: function (blockid) {
         let info = Proxmox.Utils.get_help_info(blockid);
         if (info === undefined) {
diff --git a/www/config/GCView.js b/www/config/GCView.js
index 5077f0566..2ac931cd8 100644
--- a/www/config/GCView.js
+++ b/www/config/GCView.js
@@ -183,7 +183,7 @@ Ext.define('PBS.config.GCJobView', {
             header: gettext('Schedule'),
             dataIndex: 'schedule',
             hideable: false,
-            renderer: (value) => (value ? value : Proxmox.Utils.NoneText),
+            renderer: PBS.Utils.render_schedule,
             minWidth: 85,
             flex: 1,
         },
-- 
2.47.3





  parent reply	other threads:[~2026-09-30 15:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 15:17 [PATCH proxmox{,-backup} 00/14] fix #7904: Implement Enable checkboxes for all jobs Jonas Theisen
2026-09-30 15:17 ` [PATCH proxmox 01/14] fix #7904: Add 'enable' to sync job schema Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox 02/14] fix #7904: Add 'enable' to verify " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox 03/14] fix #7904: Add 'enable' to datastore config and GC " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox 04/14] fix #7904: Add 'enable' to Tape backup " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 05/14] fix #7904: Implement "Enable" checkbox for Sync jobs Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 06/14] fix #7904: Implement "Enable" checkbox for Verify jobs Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 07/14] fix #7904: Implement "Enable" checkbox for GC jobs Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 08/14] fix #7904: Implement "Enable" checkbox for Tape backup jobs Jonas Theisen
2026-09-30 15:18 ` Jonas Theisen [this message]
2026-09-30 15:18 ` [PATCH proxmox-backup 10/14] fix #7904: Improve visibility of disabled Verify jobs on the overview page Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 11/14] fix #7904: Improve visibility of disabled Sync " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 12/14] fix #7904: Improve visibility of disabled Tape Backup " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 13/14] fix #7904: Remove clear button from calendar selector Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 14/14] fix #7904: Align Prune Edit window to other "Enable" checkboxes Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930152131.317493-10-j.theisen@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal