From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 259F31FF0B6 for ; Wed, 30 Sep 2026 17:22:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EBAD521662; Wed, 30 Sep 2026 17:22:26 +0200 (CEST) From: Jonas Theisen To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 09/14] fix #7904: Improve visibility of disabled GC on the overview page Date: Wed, 30 Sep 2026 17:18:07 +0200 Message-ID: <20260930152131.317493-10-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260930152131.317493-1-j.theisen@proxmox.com> References: <20260930152131.317493-1-j.theisen@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790781742662 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.219 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LHE2RLWFKTVNXIPGEVSWJFWVRB2XYE5V X-Message-ID-Hash: LHE2RLWFKTVNXIPGEVSWJFWVRB2XYE5V X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This commit adds additional logic to prominently display if a GC job was disabled on the GC overview page. If the GC is disabled the text "Disabled" is shown instead of the schedule which is still present in the config file. For backwords compatibility if no schedule is defined the fallback is still None. Signed-off-by: Jonas Theisen --- www/Utils.js | 10 ++++++++++ www/config/GCView.js | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/www/Utils.js b/www/Utils.js index d6bfd459e..8abbeee57 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -335,6 +335,16 @@ Ext.define('PBS.Utils', { ); }, + render_schedule: function (val, metadat, record) { + if(record.data.enable === false) { + return gettext('Disabled'); + } + if(val) { + return val; + } + return Proxmox.Utils.NoneText; + }, + get_help_tool: function (blockid) { let info = Proxmox.Utils.get_help_info(blockid); if (info === undefined) { diff --git a/www/config/GCView.js b/www/config/GCView.js index 5077f0566..2ac931cd8 100644 --- a/www/config/GCView.js +++ b/www/config/GCView.js @@ -183,7 +183,7 @@ Ext.define('PBS.config.GCJobView', { header: gettext('Schedule'), dataIndex: 'schedule', hideable: false, - renderer: (value) => (value ? value : Proxmox.Utils.NoneText), + renderer: PBS.Utils.render_schedule, minWidth: 85, flex: 1, }, -- 2.47.3