public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox{,-backup} 00/14] fix #7904: Implement Enable checkboxes for all jobs
Date: Wed, 30 Sep 2026 17:17:58 +0200	[thread overview]
Message-ID: <20260930152131.317493-1-j.theisen@proxmox.com> (raw)

This patch series looks bigger than it actually is or rather
has a lot of repetition in it.
Most commits implement the same thing just for a different
component or job.

Goal of this patch series is to allow users to disable tasks
without having to remove their current schedule.
This was already possible for Prune jobs.

Backwards compatibiltiy was kept in mind so that existing
jobs wiithout schedules would not need manual intervention.
They will get updated and adapt the new scheme on the next
actual user change.

The patches called "improve visibility" introduce the necessary
changes to hide the "next-run" timestamp in the overview page.

The patches depend on each other in the way that the first
patch of each "kind" introduces a new function or a new scheme
which is then also used in later commits.
If this is bad practice please give according feedback and i will
split that out either in a v2 or in future patches.

The "remove clear" patch is to be considered optional as it does not
interfere with the functionality of the checkboxes but was rather
added from a personal perspective that this would improve UX.

The patches for the tape jobs were not directly tested since
i did not have a PBS with a (virtual) tape drive at hand.

Thanks @d.csapak for the feedback and help already provided off-list!

proxmox:

Jonas Theisen (4):
  fix #7904: Add 'enable' to sync job schema
  fix #7904: Add 'enable' to verify job schema
  fix #7904: Add 'enable' to datastore config and GC job schema
  fix #7904: Add 'enable' to Tape backup job schema

 pbs-api-types/src/datastore.rs | 12 ++++++++++++
 pbs-api-types/src/jobs.rs      | 24 ++++++++++++++++++++++++
 2 files changed, 36 insertions(+)


proxmox-backup:

Jonas Theisen (10):
  fix #7904: Implement "Enable" checkbox for Sync jobs
  fix #7904: Implement "Enable" checkbox for Verify jobs
  fix #7904: Implement "Enable" checkbox for GC jobs
  fix #7904: Implement "Enable" checkbox for Tape backup jobs
  fix #7904: Improve visibility of disabled GC on the overview page
  fix #7904: Improve visibility of disabled Verify jobs on the overview
    page
  fix #7904: Improve visibility of disabled Sync jobs on the overview
    page
  fix #7904: Improve visibility of disabled Tape Backup jobs on the
    overview page
  fix #7904: Remove clear button from calendar selector
  fix #7904: Align Prune Edit window to other "Enable" checkboxes

 src/api2/admin/datastore.rs      |  1 +
 src/api2/admin/gc.rs             | 16 ++++++++++++-
 src/api2/admin/sync.rs           | 10 +++++++-
 src/api2/admin/verify.rs         | 10 +++++++-
 src/api2/config/datastore.rs     |  4 ++++
 src/api2/config/sync.rs          |  4 ++++
 src/api2/config/verify.rs        |  3 +++
 src/api2/tape/backup.rs          | 11 ++++++++-
 src/bin/proxmox-backup-proxy.rs  | 32 ++++++++++++++++++++++++++
 www/Utils.js                     | 10 ++++++++
 www/config/GCView.js             |  4 +++-
 www/config/SyncView.js           |  2 ++
 www/config/VerifyView.js         |  2 ++
 www/form/CalendarEvent.js        | 19 ----------------
 www/tape/BackupJobs.js           |  2 ++
 www/tape/window/TapeBackupJob.js | 30 ++++++++++++++++++++++--
 www/window/GCJobEdit.js          | 39 ++++++++++++++++++++++++++++----
 www/window/PruneJobEdit.js       | 10 +++++++-
 www/window/SyncJobEdit.js        | 26 +++++++++++++++++++--
 www/window/VerifyJobEdit.js      | 30 ++++++++++++++++++++++--
 20 files changed, 229 insertions(+), 36 deletions(-)


Summary over all repositories:
  22 files changed, 265 insertions(+), 36 deletions(-)

-- 
Generated by murpp 0.12.1




             reply	other threads:[~2026-09-30 15:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 15:17 Jonas Theisen [this message]
2026-09-30 15:17 ` [PATCH proxmox 01/14] fix #7904: Add 'enable' to sync job schema Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox 02/14] fix #7904: Add 'enable' to verify " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox 03/14] fix #7904: Add 'enable' to datastore config and GC " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox 04/14] fix #7904: Add 'enable' to Tape backup " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 05/14] fix #7904: Implement "Enable" checkbox for Sync jobs Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 06/14] fix #7904: Implement "Enable" checkbox for Verify jobs Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 07/14] fix #7904: Implement "Enable" checkbox for GC jobs Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 08/14] fix #7904: Implement "Enable" checkbox for Tape backup jobs Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 09/14] fix #7904: Improve visibility of disabled GC on the overview page Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 10/14] fix #7904: Improve visibility of disabled Verify jobs " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 11/14] fix #7904: Improve visibility of disabled Sync " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 12/14] fix #7904: Improve visibility of disabled Tape Backup " Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 13/14] fix #7904: Remove clear button from calendar selector Jonas Theisen
2026-09-30 15:18 ` [PATCH proxmox-backup 14/14] fix #7904: Align Prune Edit window to other "Enable" checkboxes Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930152131.317493-1-j.theisen@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal