From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C18551FF0C0 for ; Wed, 30 Sep 2026 17:21:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5834221515; Wed, 30 Sep 2026 17:21:57 +0200 (CEST) From: Jonas Theisen To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox{,-backup} 00/14] fix #7904: Implement Enable checkboxes for all jobs Date: Wed, 30 Sep 2026 17:17:58 +0200 Message-ID: <20260930152131.317493-1-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790781711968 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.257 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UBVU4F5I6Q56T5BTHSVECRPXQHVNSKQV X-Message-ID-Hash: UBVU4F5I6Q56T5BTHSVECRPXQHVNSKQV X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch series looks bigger than it actually is or rather has a lot of repetition in it. Most commits implement the same thing just for a different component or job. Goal of this patch series is to allow users to disable tasks without having to remove their current schedule. This was already possible for Prune jobs. Backwards compatibiltiy was kept in mind so that existing jobs wiithout schedules would not need manual intervention. They will get updated and adapt the new scheme on the next actual user change. The patches called "improve visibility" introduce the necessary changes to hide the "next-run" timestamp in the overview page. The patches depend on each other in the way that the first patch of each "kind" introduces a new function or a new scheme which is then also used in later commits. If this is bad practice please give according feedback and i will split that out either in a v2 or in future patches. The "remove clear" patch is to be considered optional as it does not interfere with the functionality of the checkboxes but was rather added from a personal perspective that this would improve UX. The patches for the tape jobs were not directly tested since i did not have a PBS with a (virtual) tape drive at hand. Thanks @d.csapak for the feedback and help already provided off-list! proxmox: Jonas Theisen (4): fix #7904: Add 'enable' to sync job schema fix #7904: Add 'enable' to verify job schema fix #7904: Add 'enable' to datastore config and GC job schema fix #7904: Add 'enable' to Tape backup job schema pbs-api-types/src/datastore.rs | 12 ++++++++++++ pbs-api-types/src/jobs.rs | 24 ++++++++++++++++++++++++ 2 files changed, 36 insertions(+) proxmox-backup: Jonas Theisen (10): fix #7904: Implement "Enable" checkbox for Sync jobs fix #7904: Implement "Enable" checkbox for Verify jobs fix #7904: Implement "Enable" checkbox for GC jobs fix #7904: Implement "Enable" checkbox for Tape backup jobs fix #7904: Improve visibility of disabled GC on the overview page fix #7904: Improve visibility of disabled Verify jobs on the overview page fix #7904: Improve visibility of disabled Sync jobs on the overview page fix #7904: Improve visibility of disabled Tape Backup jobs on the overview page fix #7904: Remove clear button from calendar selector fix #7904: Align Prune Edit window to other "Enable" checkboxes src/api2/admin/datastore.rs | 1 + src/api2/admin/gc.rs | 16 ++++++++++++- src/api2/admin/sync.rs | 10 +++++++- src/api2/admin/verify.rs | 10 +++++++- src/api2/config/datastore.rs | 4 ++++ src/api2/config/sync.rs | 4 ++++ src/api2/config/verify.rs | 3 +++ src/api2/tape/backup.rs | 11 ++++++++- src/bin/proxmox-backup-proxy.rs | 32 ++++++++++++++++++++++++++ www/Utils.js | 10 ++++++++ www/config/GCView.js | 4 +++- www/config/SyncView.js | 2 ++ www/config/VerifyView.js | 2 ++ www/form/CalendarEvent.js | 19 ---------------- www/tape/BackupJobs.js | 2 ++ www/tape/window/TapeBackupJob.js | 30 ++++++++++++++++++++++-- www/window/GCJobEdit.js | 39 ++++++++++++++++++++++++++++---- www/window/PruneJobEdit.js | 10 +++++++- www/window/SyncJobEdit.js | 26 +++++++++++++++++++-- www/window/VerifyJobEdit.js | 30 ++++++++++++++++++++++-- 20 files changed, 229 insertions(+), 36 deletions(-) Summary over all repositories: 22 files changed, 265 insertions(+), 36 deletions(-) -- Generated by murpp 0.12.1