public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 3/3] pull: move logging of disappeared snapshots
Date: Mon, 27 Apr 2026 10:49:49 +0200	[thread overview]
Message-ID: <20260427084952.303245-4-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20260427084952.303245-1-f.gruenbichler@proxmox.com>

to the call site where we have the log line sender available

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 src/server/pull.rs | 6 ++++++
 src/server/sync.rs | 4 ----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/server/pull.rs b/src/server/pull.rs
index d7455c2ee..f2f90b83a 100644
--- a/src/server/pull.rs
+++ b/src/server/pull.rs
@@ -662,6 +662,12 @@ async fn pull_snapshot<'a>(
         .await
         .with_context(|| prefix.clone())?
     else {
+        log_sender
+            .log(
+                Level::INFO,
+                format!("{prefix}: skipped because vanished since start of sync",),
+            )
+            .await?;
         return Ok(sync_stats);
     };
 
diff --git a/src/server/sync.rs b/src/server/sync.rs
index d0d3ab31a..a06c90801 100644
--- a/src/server/sync.rs
+++ b/src/server/sync.rs
@@ -158,10 +158,6 @@ impl SyncSourceReader for RemoteSourceReader {
             match err.downcast_ref::<HttpError>() {
                 Some(HttpError { code, message }) => match *code {
                     StatusCode::NOT_FOUND => {
-                        info!(
-                            "Snapshot {}: skipped because vanished since start of sync",
-                            &self.dir
-                        );
                         return Ok(None);
                     }
                     _ => {
-- 
2.47.3





  parent reply	other threads:[~2026-04-27  8:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  8:49 [PATCH proxmox-backup 0/3] sync: clean up manifest/archive load handling Fabian Grünbichler
2026-04-27  8:49 ` [PATCH proxmox-backup 1/3] sync: return File in load_file_into Fabian Grünbichler
2026-04-27  8:49 ` [PATCH proxmox-backup 2/3] pull: do not allow archive fetching to return no archive Fabian Grünbichler
2026-04-27  8:49 ` Fabian Grünbichler [this message]
2026-04-27  9:04 ` [PATCH proxmox-backup 0/3] sync: clean up manifest/archive load handling Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260427084952.303245-4-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal