From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 72E461FF148 for ; Mon, 27 Apr 2026 10:50:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 56A1115799; Mon, 27 Apr 2026 10:50:03 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 3/3] pull: move logging of disappeared snapshots Date: Mon, 27 Apr 2026 10:49:49 +0200 Message-ID: <20260427084952.303245-4-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260427084952.303245-1-f.gruenbichler@proxmox.com> References: <20260427084952.303245-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777279702308 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JK3AY7WTD3H37G4W64RMR3OT64BWJUI7 X-Message-ID-Hash: JK3AY7WTD3H37G4W64RMR3OT64BWJUI7 X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: to the call site where we have the log line sender available Signed-off-by: Fabian Grünbichler --- src/server/pull.rs | 6 ++++++ src/server/sync.rs | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/server/pull.rs b/src/server/pull.rs index d7455c2ee..f2f90b83a 100644 --- a/src/server/pull.rs +++ b/src/server/pull.rs @@ -662,6 +662,12 @@ async fn pull_snapshot<'a>( .await .with_context(|| prefix.clone())? else { + log_sender + .log( + Level::INFO, + format!("{prefix}: skipped because vanished since start of sync",), + ) + .await?; return Ok(sync_stats); }; diff --git a/src/server/sync.rs b/src/server/sync.rs index d0d3ab31a..a06c90801 100644 --- a/src/server/sync.rs +++ b/src/server/sync.rs @@ -158,10 +158,6 @@ impl SyncSourceReader for RemoteSourceReader { match err.downcast_ref::() { Some(HttpError { code, message }) => match *code { StatusCode::NOT_FOUND => { - info!( - "Snapshot {}: skipped because vanished since start of sync", - &self.dir - ); return Ok(None); } _ => { -- 2.47.3