From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup 0/3] sync: clean up manifest/archive load handling
Date: Mon, 27 Apr 2026 11:04:24 +0200 [thread overview]
Message-ID: <1777280633.voijfg919s.astroid@yuna.none> (raw)
In-Reply-To: <20260427084952.303245-1-f.gruenbichler@proxmox.com>
forgot to add this here - this would be an alternative to Dominik's
patch in https://lore.proxmox.com/pbs-devel/1777277236.2hvl2my85r.astroid@yuna.none
On April 27, 2026 10:49 am, Fabian Grünbichler wrote:
> this series cleans up load_file_into by
> - moving the File -> DataBlob conversion to the manifest variant call
> site
> - moving the "skip snapshot" logging to the call site to allow using a
> LogLineSender
>
> Fabian Grünbichler (3):
> sync: return File in load_file_into
> pull: do not allow archive fetching to return no archive
> pull: move logging of disappeared snapshots
>
> src/server/pull.rs | 19 ++++++++++++++++---
> src/server/sync.rs | 14 +++++---------
> 2 files changed, 21 insertions(+), 12 deletions(-)
prev parent reply other threads:[~2026-04-27 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 8:49 [PATCH proxmox-backup 0/3] sync: clean up manifest/archive load handling Fabian Grünbichler
2026-04-27 8:49 ` [PATCH proxmox-backup 1/3] sync: return File in load_file_into Fabian Grünbichler
2026-04-27 8:49 ` [PATCH proxmox-backup 2/3] pull: do not allow archive fetching to return no archive Fabian Grünbichler
2026-04-27 8:49 ` [PATCH proxmox-backup 3/3] pull: move logging of disappeared snapshots Fabian Grünbichler
2026-04-27 9:04 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1777280633.voijfg919s.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox