* [PATCH proxmox-backup] ui: encryption keys: always enable tape encryption restore button
@ 2026-04-24 11:52 Dominik Csapak
0 siblings, 0 replies; only message in thread
From: Dominik Csapak @ 2026-04-24 11:52 UTC (permalink / raw)
To: pbs-devel
Restoring a tape key should not require an existing tape key to select,
since it will be a new key, not overwriting the existing one.
(In the tape backup -> encryption keys view it's also always enabled)
To do that, remove the disabled/enableFn properties, but then the
component must be a 'button' (a proxmoxButton needs a record for it
to be enabled).
To make it a bit clearer that it does not have anything to do with the
listed keys, rename it to 'Restore Tape Key' and move it over to the
right of the toolbar.
While touching this, rename 'restoreEncryptionKey' to
'restoreTapeEncryptionKey' to make it also clearer in the code what it
does.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/config/EncryptionKeysView.js | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/www/config/EncryptionKeysView.js b/www/config/EncryptionKeysView.js
index cdcd986a6..0f9367c72 100644
--- a/www/config/EncryptionKeysView.js
+++ b/www/config/EncryptionKeysView.js
@@ -112,7 +112,7 @@ Ext.define('PBS.config.EncryptionKeysView', {
}).show();
},
- restoreEncryptionKey: function () {
+ restoreTapeEncryptionKey: function () {
Ext.create('Proxmox.window.Edit', {
title: gettext('Restore Key'),
isCreate: true,
@@ -275,13 +275,11 @@ Ext.define('PBS.config.EncryptionKeysView', {
(item.data.type === 'sync' && !!item.data['archived-at']) ||
item.data.type === 'tape',
},
- '-',
+ '->',
{
- text: gettext('Restore Key'),
- xtype: 'proxmoxButton',
- handler: 'restoreEncryptionKey',
- disabled: true,
- enableFn: (item) => item.data.type === 'tape',
+ text: gettext('Restore Tape Key'),
+ xtype: 'button',
+ handler: 'restoreTapeEncryptionKey',
},
],
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-04-24 12:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-24 11:52 [PATCH proxmox-backup] ui: encryption keys: always enable tape encryption restore button Dominik Csapak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox