public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup] ui: encryption keys: always enable tape encryption restore button
Date: Fri, 24 Apr 2026 13:52:09 +0200	[thread overview]
Message-ID: <20260424115215.2377890-1-d.csapak@proxmox.com> (raw)

Restoring a tape key should not require an existing tape key to select,
since it will be a new key, not overwriting the existing one.
(In the tape backup -> encryption keys view it's also always enabled)

To do that, remove the disabled/enableFn properties, but then the
component must be a 'button' (a proxmoxButton needs a record for it
to be enabled).

To make it a bit clearer that it does not have anything to do with the
listed keys, rename it to 'Restore Tape Key' and move it over to the
right of the toolbar.

While touching this, rename 'restoreEncryptionKey' to
'restoreTapeEncryptionKey' to make it also clearer in the code what it
does.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/config/EncryptionKeysView.js | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/www/config/EncryptionKeysView.js b/www/config/EncryptionKeysView.js
index cdcd986a6..0f9367c72 100644
--- a/www/config/EncryptionKeysView.js
+++ b/www/config/EncryptionKeysView.js
@@ -112,7 +112,7 @@ Ext.define('PBS.config.EncryptionKeysView', {
             }).show();
         },
 
-        restoreEncryptionKey: function () {
+        restoreTapeEncryptionKey: function () {
             Ext.create('Proxmox.window.Edit', {
                 title: gettext('Restore Key'),
                 isCreate: true,
@@ -275,13 +275,11 @@ Ext.define('PBS.config.EncryptionKeysView', {
                 (item.data.type === 'sync' && !!item.data['archived-at']) ||
                 item.data.type === 'tape',
         },
-        '-',
+        '->',
         {
-            text: gettext('Restore Key'),
-            xtype: 'proxmoxButton',
-            handler: 'restoreEncryptionKey',
-            disabled: true,
-            enableFn: (item) => item.data.type === 'tape',
+            text: gettext('Restore Tape Key'),
+            xtype: 'button',
+            handler: 'restoreTapeEncryptionKey',
         },
     ],
 
-- 
2.47.3





                 reply	other threads:[~2026-04-24 12:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260424115215.2377890-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal