From: Robert Obkircher <r.obkircher@proxmox.com>
To: "Max R. Carrara" <m.carrara@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup 2/2] pbs-tape: rename `buffer` to `header`
Date: Thu, 06 Aug 2026 12:57:11 +0200 [thread overview]
Message-ID: <178601383145.99099.10335181077951352838.b4-review@b4> (raw)
In-Reply-To: <20260805141620.4190773-3-m.carrara@proxmox.com>
> ... since `BlockHeader` is now a smart pointer.
>
> Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
>
> diff --git a/pbs-tape/src/blocked_reader.rs b/pbs-tape/src/blocked_reader.rs
> index 33c5db780..9ad16c91f 100644
> --- a/pbs-tape/src/blocked_reader.rs
> +++ b/pbs-tape/src/blocked_reader.rs
> @@ -18,7 +18,7 @@ use crate::{
> /// the end of the stream).
> pub struct BlockedReader<R> {
> reader: R,
> - buffer: BlockHeader,
> + header: BlockHeader,
I'm confused about the naming. Shouldn't this be something more like
`buffer: BlockBuffer` which then consists of a few header fields plus a
payload? Or is the payload really part of the header?
--
Robert Obkircher <r.obkircher@proxmox.com>
next prev parent reply other threads:[~2026-08-06 10:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 14:16 [PATCH proxmox-backup 0/2] Fix Undefined Behavior in Tape Block Header Deallocation Max R. Carrara
2026-08-05 14:16 ` [PATCH proxmox-backup 1/2] pbs-tape: fix undefined behavior in block header deallocation Max R. Carrara
2026-08-06 10:57 ` Robert Obkircher
2026-08-07 12:47 ` Max R. Carrara
2026-08-05 14:16 ` [PATCH proxmox-backup 2/2] pbs-tape: rename `buffer` to `header` Max R. Carrara
2026-08-06 10:57 ` Robert Obkircher [this message]
2026-08-07 12:52 ` Max R. Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178601383145.99099.10335181077951352838.b4-review@b4 \
--to=r.obkircher@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox