Re: [PATCH proxmox-backup 2/2] pbs-tape: rename `buffer` to `header`

["Max R. Carrara" <m.carrara@proxmox.com>]

On Thu Aug 6, 2026 at 12:57 PM CEST, Robert Obkircher wrote:
> > ... since `BlockHeader` is now a smart pointer.
> >
> > Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
> >
> > diff --git a/pbs-tape/src/blocked_reader.rs b/pbs-tape/src/blocked_reader.rs
> > index 33c5db780..9ad16c91f 100644
> > --- a/pbs-tape/src/blocked_reader.rs
> > +++ b/pbs-tape/src/blocked_reader.rs
> > @@ -18,7 +18,7 @@ use crate::{
> >  /// the end of the stream).
> >  pub struct BlockedReader<R> {
> >      reader: R,
> > -    buffer: BlockHeader,
> > +    header: BlockHeader,
>
> I'm confused about the naming. Shouldn't this be something more like
> `buffer: BlockBuffer` which then consists of a few header fields plus a
> payload? Or is the payload really part of the header?

AFAIU the `BlockHeader` struct refers to an entire block of data written
to / read from tape (header + payload) -- so I think it's overall a bit
of a misnomer, yes.

That being said, I don't mind renaming this (and its related structs) as
part of a different series, perhaps including an overall cleanup as
well, where applicable.