From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BACA21FF0E0 for ; Thu, 06 Aug 2026 12:57:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 87FD12152B; Thu, 06 Aug 2026 12:57:27 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH proxmox-backup 2/2] pbs-tape: rename `buffer` to `header` From: Robert Obkircher To: "Max R. Carrara" In-Reply-To: <20260805141620.4190773-3-m.carrara@proxmox.com> References: <20260805141620.4190773-1-m.carrara@proxmox.com> <20260805141620.4190773-3-m.carrara@proxmox.com> Date: Thu, 06 Aug 2026 12:57:11 +0200 Message-Id: <178601383145.99099.10335181077951352838.b4-review@b4> X-Mailer: b4 0.16-dev X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786013829570 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.132 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EM7BTOXV6KOOEAZQUEZM5UJW7BZRHT7E X-Message-ID-Hash: EM7BTOXV6KOOEAZQUEZM5UJW7BZRHT7E X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > ... since `BlockHeader` is now a smart pointer. > > Signed-off-by: Max R. Carrara > > diff --git a/pbs-tape/src/blocked_reader.rs b/pbs-tape/src/blocked_reader.rs > index 33c5db780..9ad16c91f 100644 > --- a/pbs-tape/src/blocked_reader.rs > +++ b/pbs-tape/src/blocked_reader.rs > @@ -18,7 +18,7 @@ use crate::{ > /// the end of the stream). > pub struct BlockedReader { > reader: R, > - buffer: BlockHeader, > + header: BlockHeader, I'm confused about the naming. Shouldn't this be something more like `buffer: BlockBuffer` which then consists of a few header fields plus a payload? Or is the payload really part of the header? -- Robert Obkircher