public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-backup] client: show full error context in single line on upload errors
@ 2026-04-27 12:59 Christian Ebner
  2026-04-28  1:26 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2026-04-27 12:59 UTC (permalink / raw)
  To: pbs-devel

Since commit 07cb3e7f7 ("client: pxar: optionally split metadata and
payload streams") there are possibly multiple upload streams (data
and metadata archive), errors for each propagated accordingly.
Since this reformatted the error without explicitly including the
context, the resulting error messages are lacking crucial information.

Reformat the error with full context.

Fixes: 07cb3e7f7 ("client: pxar: optionally split metadata and payload streams")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-backup-client/src/main.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
index 1c1ad9a0f..a1533b79b 100644
--- a/proxmox-backup-client/src/main.rs
+++ b/proxmox-backup-client/src/main.rs
@@ -322,10 +322,10 @@ async fn backup_directory<P: AsRef<Path>>(
 
         match futures::join!(stats, payload_stats) {
             (Ok(stats), Ok(payload_stats)) => Ok((stats, Some(payload_stats))),
-            (Err(err), Ok(_)) => Err(format_err!("upload failed: {err}")),
-            (Ok(_), Err(err)) => Err(format_err!("upload failed: {err}")),
+            (Err(err), Ok(_)) => Err(format_err!("upload failed: {err:#}")),
+            (Ok(_), Err(err)) => Err(format_err!("upload failed: {err:#}")),
             (Err(err), Err(payload_err)) => {
-                Err(format_err!("upload failed: {err} - {payload_err}"))
+                Err(format_err!("upload failed: {err:#} - {payload_err:#}"))
             }
         }
     } else {
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-28  1:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 12:59 [PATCH proxmox-backup] client: show full error context in single line on upload errors Christian Ebner
2026-04-28  1:26 ` applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal