From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup] client: show full error context in single line on upload errors
Date: Mon, 27 Apr 2026 14:59:55 +0200 [thread overview]
Message-ID: <20260427125955.653377-1-c.ebner@proxmox.com> (raw)
Since commit 07cb3e7f7 ("client: pxar: optionally split metadata and
payload streams") there are possibly multiple upload streams (data
and metadata archive), errors for each propagated accordingly.
Since this reformatted the error without explicitly including the
context, the resulting error messages are lacking crucial information.
Reformat the error with full context.
Fixes: 07cb3e7f7 ("client: pxar: optionally split metadata and payload streams")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
proxmox-backup-client/src/main.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs
index 1c1ad9a0f..a1533b79b 100644
--- a/proxmox-backup-client/src/main.rs
+++ b/proxmox-backup-client/src/main.rs
@@ -322,10 +322,10 @@ async fn backup_directory<P: AsRef<Path>>(
match futures::join!(stats, payload_stats) {
(Ok(stats), Ok(payload_stats)) => Ok((stats, Some(payload_stats))),
- (Err(err), Ok(_)) => Err(format_err!("upload failed: {err}")),
- (Ok(_), Err(err)) => Err(format_err!("upload failed: {err}")),
+ (Err(err), Ok(_)) => Err(format_err!("upload failed: {err:#}")),
+ (Ok(_), Err(err)) => Err(format_err!("upload failed: {err:#}")),
(Err(err), Err(payload_err)) => {
- Err(format_err!("upload failed: {err} - {payload_err}"))
+ Err(format_err!("upload failed: {err:#} - {payload_err:#}"))
}
}
} else {
--
2.47.3
reply other threads:[~2026-04-27 13:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427125955.653377-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox