public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Manuel Federanko <m.federanko@proxmox.com>,
	pbs-devel@lists.proxmox.com,
	Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH proxmox-backup v2] acme: partially fix #6372: scale certificate renewal checks by lifetime
Date: Fri, 24 Apr 2026 13:11:04 +0200	[thread overview]
Message-ID: <1777028817.nszqlhr1cy.astroid@yuna.none> (raw)
In-Reply-To: <eecefc4f-e1f1-446c-9281-df52398e1605@proxmox.com>

On April 24, 2026 12:50 pm, Thomas Lamprecht wrote:
> Am 24.04.26 um 12:36 schrieb Thomas Lamprecht:
>> Am 24.04.26 um 10:35 schrieb Fabian Grünbichler:
>>> seems like v1 of this got applied (with some follow-ups), would you mind
>>> checking if rebasing the diff between v1 and v2 still makes sense?
>> Argh, b4 should have pulled in the newer revision in any case, I'll
>> recheck what was going on here.
>> 
> Probably just timing, but b4 still isn't able to find v2, might be
> due to Manuel not sending out a superseded reply to the old submission
> that points to the new one, which then made b4 not recognize the newer
> revision.

b4 doesn't look at superseded, it searches lore for matching newer
versions of the series, and it seems this particular thread is not
handled correctly, since the query ends up looking for:

((s:"acme: partially fix #6372: scale certificate renewal checks by lifetime" AND f:"s.sterz@proxmox.com")) AND d:20260422..

because it thinks the series is authored by Shannon, instead of Manuel
because it picks one of the replies as base message..

if it wouldn't misattribute that, it would also find the v2 thread (and
presumably handle it correctly)




  reply	other threads:[~2026-04-24 11:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 13:46 Manuel Federanko
2026-04-24  8:37 ` Fabian Grünbichler
2026-04-24 10:37   ` Thomas Lamprecht
2026-04-24 10:50     ` Thomas Lamprecht
2026-04-24 11:11       ` Fabian Grünbichler [this message]
2026-04-24 11:40   ` Manuel Federanko
2026-04-24 16:49 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1777028817.nszqlhr1cy.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=m.federanko@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal