From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3F97A1FF140 for ; Fri, 24 Apr 2026 13:11:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0C6141425F; Fri, 24 Apr 2026 13:11:43 +0200 (CEST) Date: Fri, 24 Apr 2026 13:11:04 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH proxmox-backup v2] acme: partially fix #6372: scale certificate renewal checks by lifetime To: Manuel Federanko , pbs-devel@lists.proxmox.com, Thomas Lamprecht References: <20260423134607.105229-2-m.federanko@proxmox.com> <1777019789.wslwp6i17e.astroid@yuna.none> <7c18fb73-e517-42a6-b5fe-15dbe4c2412f@proxmox.com> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1777028817.nszqlhr1cy.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777028977403 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FJO7YADX6ZBGP4BLG2WY2BFUTS3EIFC4 X-Message-ID-Hash: FJO7YADX6ZBGP4BLG2WY2BFUTS3EIFC4 X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On April 24, 2026 12:50 pm, Thomas Lamprecht wrote: > Am 24.04.26 um 12:36 schrieb Thomas Lamprecht: >> Am 24.04.26 um 10:35 schrieb Fabian Gr=C3=BCnbichler: >>> seems like v1 of this got applied (with some follow-ups), would you min= d >>> checking if rebasing the diff between v1 and v2 still makes sense? >> Argh, b4 should have pulled in the newer revision in any case, I'll >> recheck what was going on here. >>=20 > Probably just timing, but b4 still isn't able to find v2, might be > due to Manuel not sending out a superseded reply to the old submission > that points to the new one, which then made b4 not recognize the newer > revision. b4 doesn't look at superseded, it searches lore for matching newer versions of the series, and it seems this particular thread is not handled correctly, since the query ends up looking for: ((s:"acme: partially fix #6372: scale certificate renewal checks by lifetim= e" AND f:"s.sterz@proxmox.com")) AND d:20260422.. because it thinks the series is authored by Shannon, instead of Manuel because it picks one of the replies as base message.. if it wouldn't misattribute that, it would also find the v2 thread (and presumably handle it correctly)