From: Manuel Federanko <m.federanko@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2] acme: partially fix #6372: scale certificate renewal checks by lifetime
Date: Fri, 24 Apr 2026 13:40:33 +0200 [thread overview]
Message-ID: <b8e5bd1b-bfbc-4b9e-befa-cd4b0157ed22@proxmox.com> (raw)
In-Reply-To: <1777019789.wslwp6i17e.astroid@yuna.none>
On 2026-04-24 10:35 AM, Fabian Grünbichler wrote:
> seems like v1 of this got applied (with some follow-ups), would you mind
> checking if rebasing the diff between v1 and v2 still makes sense?
They could be rebased, but seeing as ARI support would change some stuff
anyways I'm not quiet sure if it is worth it. I'd rather incorporate
these improvements into the ARI patch-series I'm working on.
> On April 23, 2026 3:46 pm, Manuel Federanko wrote:
>> Start renewing a certificate once 2/3 or 1/2 (for short-lived
>> certificates) of its total lifetime have passed, instead of the
>> hardcoded 30 days. This stays consistent with many certificates, which
>> are valid for 90 days and is recommended by letsencrypt [1].
>>
>> The update service runs daily, impose a 3 day minimum remaining lifetime
>> to still be able to handle transient failures for certificate renewals.
>>
>> [1] https://letsencrypt.org/docs/integration-guide/#when-to-renew
>>
>> Signed-off-by: Manuel Federanko <m.federanko@proxmox.com>
>> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6372
next prev parent reply other threads:[~2026-04-24 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 13:46 Manuel Federanko
2026-04-24 8:37 ` Fabian Grünbichler
2026-04-24 10:37 ` Thomas Lamprecht
2026-04-24 10:50 ` Thomas Lamprecht
2026-04-24 11:11 ` Fabian Grünbichler
2026-04-24 11:40 ` Manuel Federanko [this message]
2026-04-24 16:49 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e5bd1b-bfbc-4b9e-befa-cd4b0157ed22@proxmox.com \
--to=m.federanko@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox