Re: [PATCH v1 proxmox-backup 2/3] client: pxar: consistently ignore vanished files and warn about them

[Christian Ebner <c.ebner@proxmox.com>]

On 5/11/26 10:25 AM, Robert Obkircher wrote:
> 
> On 08.05.26 16:11, Christian Ebner wrote:
>> On 5/8/26 4:01 PM, Robert Obkircher wrote:
>>>
>>> On 08.05.26 15:24, Christian Ebner wrote:
>>>> [..]
>>>>
>>>> In that case could you include a patch to cleanup the (one) other
>>>> implicit context creation?
>>>
>>> Which one? I don't see another one
>>
>> I was referring to:
>>
>> https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=pbs-client/src/pxar/create.rs;h=d18021c4c57620897c8a1122f521365f913573e9;hb=HEAD#l709
>>
>>
>> Should be
>>
>> diff --git a/pbs-client/src/pxar/create.rs
>> b/pbs-client/src/pxar/create.rs
>> index d18021c4c..fe3f851f2 100644
>> --- a/pbs-client/src/pxar/create.rs
>> +++ b/pbs-client/src/pxar/create.rs
>> @@ -707,7 +707,7 @@ impl Archiver {
>>                       continue;
>>                   }
>>                   Err(err) => {
>> -                    return Err(err).with_context(|| format!("stat
>> failed on {full_path:?}"))
>> +                    return Err(err).context(format!("stat failed on
>> {full_path:?}"))
>>                   }
>>               }
> 
> This patch already deletes that line.

Oh, right, seems I was not looking at the patched state (should avoid 
doing to much stuff in parallel :/).

Sorry for the noise.