From: Kaiyang Wu <wukaiyang2003@gmail.com>
To: David Riley <d.riley@proxmox.com>, pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH pve-container] setup: openeuler: use network scripts to setup network
Date: Wed, 29 Jul 2026 16:45:18 +0800 [thread overview]
Message-ID: <f3f005b4-5313-4d7c-b18a-bf5e685b928a@gmail.com> (raw)
In-Reply-To: <0c3096fd-d398-4b14-923f-8d7941a6df93@gmail.com>
Gentle ping. For the network stack, since the upstream still prefers
legacy network scripts on x86_64 and aarch64, is it OK to just use
network scripts for now?
Kaiyang
On 2026-07-15 17:04, Kaiyang Wu wrote:
> On 2026-07-14 16:09, David Riley wrote:
>> Please split this up into two commits one focusing on the typo and the
>> other
>> one fixing the issue.
>
>>
>> This does not work. It does allow the container to be created, but
>> it won't set a configured static IP address correctly.
>> I tested it with:
>>
>> cat /etc/os-release
>> NAME="openEuler"
>> VERSION="24.03 (LTS-SP4)"
>>
>> I think it should be:
>> $self->setup_network_with_network_scripts($conf);
>> instead.
>
> I will address these issues in v2.
>
>> But I think we need to take this fix in a different direction altogether.
>>
>> Overriding setup_network here to force legacy network scripts
>> bypasses the root cause of the issue. The actual bug is that CentOS.pm
>> crashes
>> when /etc/redhat-release is missing, which prevents it from choosing the
>> correct network setup.
>>
>> Hardcoding the legacy fallback here should not be the way to go
>> forward here.
>> OpenEuler already includes and prefers NetworkManager, as listed in the
>> linuxcontainers.org yaml you linked [0]. Forcing legacy network scripts
>> is not a future proof solution, as it already has been deprecated
>> upstream
>> (see: RHEL 8 [1]).
>>
>> So what this patch needs is something similar to the version check in
>> CentOS.pm
>> using the alternative path /etc/os-release instead.
>>
>> [0] https://github.com/lxc/lxc-ci/
>> blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L250
>> [1] https://docs.redhat.com/en/documentation/
>> red_hat_enterprise_linux/8/ html/8.4_release_notes/
>> deprecated_functionality#deprecated- functionality_networking
>
> The upstream yaml still prefers legacy network scripts on x86_64 and
> aarch64 [0], despite preferring NetworkManager on armhfp [1].
>
> [0] https://github.com/lxc/lxc-ci/
> blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/
> openeuler.yaml#L245-L247
> [1] https://github.com/lxc/lxc-ci/
> blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/
> openeuler.yaml#L256-L257
>
> Best,
> Kaiyang
>
prev parent reply other threads:[~2026-07-29 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 12:14 [PATCH pve-container] setup: openeuler: use network scripts to setup network Kaiyang Wu
2026-07-13 3:15 ` Kaiyang Wu
2026-07-14 8:09 ` David Riley
2026-07-15 9:04 ` Kaiyang Wu
2026-07-29 8:45 ` Kaiyang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f005b4-5313-4d7c-b18a-bf5e685b928a@gmail.com \
--to=wukaiyang2003@gmail.com \
--cc=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=wukaiyang@loongfans.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.