From: Kaiyang Wu <wukaiyang2003@gmail.com>
To: pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH pve-container] setup: openeuler: use network scripts to setup network
Date: Mon, 13 Jul 2026 11:15:59 +0800 [thread overview]
Message-ID: <3ea4bff8-41c1-4823-a9cc-9922f21ad443@gmail.com> (raw)
In-Reply-To: <20260706121458.73398-1-wukaiyang@loongfans.cn>
Gentle ping, can anyone please take a look?
Kaiyang
On 2026-07-06 20:14, Kaiyang Wu wrote:
> Fix the error "can't open '/etc/redhat-release' - No such file or
> directory".
>
> Fix the typo "netork" => "network".
>
> openEuler does not provide '/etc/redhat-release', which causes an error
> during network setup, as the setup script attempts to distinguishes
> RedHat releases, whereas openEular never shipped this file.
>
> openEuler defaults to use network scripts in LXC templates shipped by
> linuxcontainers.org. [0]
>
> [0] https://github.com/lxc/lxc-ci/blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L239
>
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
> src/PVE/LXC/Setup/CentOS.pm | 4 ++--
> src/PVE/LXC/Setup/OpenEuler.pm | 6 ++++++
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
> index 2469046..7e8140b 100644
> --- a/src/PVE/LXC/Setup/CentOS.pm
> +++ b/src/PVE/LXC/Setup/CentOS.pm
> @@ -197,7 +197,7 @@ sub setup_network {
> # With CentOS/AlmaLinux/... 10 the support for network scripts got dropped.
> setup_network_with_networkmanager($self, $conf);
> } else {
> - setup_netork_with_network_scripts($self, $conf);
> + setup_network_with_network_scripts($self, $conf);
> }
> }
>
> @@ -284,7 +284,7 @@ sub setup_network_with_networkmanager {
> }
> }
>
> -sub setup_netork_with_network_scripts {
> +sub setup_network_with_network_scripts {
> my ($self, $conf) = @_;
>
> my ($gw, $gw6);
> diff --git a/src/PVE/LXC/Setup/OpenEuler.pm b/src/PVE/LXC/Setup/OpenEuler.pm
> index 9bfd5c4..185ff5a 100644
> --- a/src/PVE/LXC/Setup/OpenEuler.pm
> +++ b/src/PVE/LXC/Setup/OpenEuler.pm
> @@ -33,4 +33,10 @@ sub setup_init {
> $self->setup_systemd_preset();
> }
>
> +sub setup_network {
> + my ($self, $conf) = @_;
> +
> + $self->setup_network_with_network_scripts($self, $conf);
> +}
> +
> 1;
next prev parent reply other threads:[~2026-07-13 3:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 12:14 [PATCH pve-container] setup: openeuler: use network scripts to setup network Kaiyang Wu
2026-07-13 3:15 ` Kaiyang Wu [this message]
2026-07-14 8:09 ` David Riley
2026-07-15 9:04 ` Kaiyang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ea4bff8-41c1-4823-a9cc-9922f21ad443@gmail.com \
--to=wukaiyang2003@gmail.com \
--cc=pve-devel@lists.proxmox.com \
--cc=wukaiyang@loongfans.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.