Re: [PATCH pve-container] setup: openeuler: use network scripts to setup network

[Kaiyang Wu <wukaiyang2003@gmail.com>]

On 2026-07-14 16:09, David Riley wrote:
> Please split this up into two commits one focusing on the typo and the 
> other
> one fixing the issue.

> 
> This does not work. It does allow the container to be created, but
> it won't set a configured static IP address correctly.
> I tested it with:
> 
> cat /etc/os-release
> NAME="openEuler"
> VERSION="24.03 (LTS-SP4)"
> 
> I think it should be:
> $self->setup_network_with_network_scripts($conf);
> instead.

I will address these issues in v2.

> But I think we need to take this fix in a different direction altogether.
> 
> Overriding setup_network here to force legacy network scripts
> bypasses the root cause of the issue. The actual bug is that CentOS.pm 
> crashes
> when /etc/redhat-release is missing, which prevents it from choosing the
> correct network setup.
> 
> Hardcoding the legacy fallback here should not be the way to go forward 
> here.
> OpenEuler already includes and prefers NetworkManager, as listed in the
> linuxcontainers.org yaml you linked [0]. Forcing legacy network scripts
> is not a future proof solution, as it already has been deprecated upstream
> (see: RHEL 8 [1]).
> 
> So what this patch needs is something similar to the version check in 
> CentOS.pm
> using the alternative path /etc/os-release instead.
> 
> [0] https://github.com/lxc/lxc-ci/ 
> blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L250
> [1] https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/ 
> html/8.4_release_notes/deprecated_functionality#deprecated- 
> functionality_networking

The upstream yaml still prefers legacy network scripts on x86_64 and 
aarch64 [0], despite preferring NetworkManager on armhfp [1].

[0] 
https://github.com/lxc/lxc-ci/blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L245-L247
[1] 
https://github.com/lxc/lxc-ci/blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L256-L257

Best,
Kaiyang