From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 127021FF0E5 for ; Wed, 29 Jul 2026 10:45:55 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D0C4920818; Wed, 29 Jul 2026 10:45:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785314721; x=1785919521; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GKwSACScvtaum/AuHApL46VDNKzJVpQbHAX8CpBHvjY=; b=W87r5xuwd3gVlHRYJwgWRCOLT24q71Y8Ccy5yLDPErx+Pfk2no6hTu7oReOr832Nb5 sLelPnrauDEHQZQOpl0Z0N9oIiqQhrqDkly5gl/4giLPcy17Ttl5XSj+cTS/lMGok3Co dOgFQpoOPFe0R/6mWA3M5pXSvyMoXV1UELZWt4e7jBga4WloL9M5Jl60oURUmFfp2FfY MjE421QtHHe+KPemyKnlu0quhspTwSVmthFU23ka1y5mhMi+3M0oK09cAZcaAd8ZJ9C8 hX9M5G4Zmf3jW6tnVjYHZEzs6XCZcadV/Y2ShHgypSYy7E9U7k4aET9ipeA+x0ikVH8/ P4QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785314721; x=1785919521; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GKwSACScvtaum/AuHApL46VDNKzJVpQbHAX8CpBHvjY=; b=l0mrAQLf9166bY0aIo3ZEPTJ7UamYtOKqPQM+1blY3wId/38AGzi6v6g8ffJzFJrgS 2LoR6iRwhqcu/0vc+Mu/MIxlZGIeXLRkqsx6WBBryKY8mcmubttoTrDa/UwRaR/LiGIQ UepCjMVIIxk8cYxPjuKYuQe164ViAejEiSh1vIvufZNP0NRVD0hLvZgKeiixxSdv5KQZ GeVwUhq/xqAq3mYopdNpwKqMVFFbxgLzVT+YVnxR38z1lGnJdjhGnj0W5O/Bomnwmfja 3tdGwa4uZYt5F5oJV+Fji5dYs/Uz+8tMBrp++BjcyMiTta9cjad1nD2BNGfxTeuqWERz muDg== X-Forwarded-Encrypted: i=1; AHgh+Rod32BMwLE5/pYSI7ua07XkIyseKRIv3bFb4KdVNO/1Gr4xbfCRBc4pnIpKt61m1KIyw5CzgiCXV7M=@lists.proxmox.com X-Gm-Message-State: AOJu0Yyo/zbNzNgg4EQWfG1gnuVRv6I6EeYqZQYw0xLrL/DSqdjYppDX Dlv9MViZUiB8fXfw0E8RgLdGqC3M3UuiDeaGYiY0HhDUtOdqbbBd4Sk3 X-Gm-Gg: AR+sD10evB5M3ERhOcqB4Kb/fFl24bYxPRg5hELnJfU6PLamvWxokhY5TV60MFhZEjj KBvBf2sGhMXrhs6yOrrEnVTekwIyxnGEA++0V8uiGU41VtZfV0WpxR+4V15vLGZjywqyWKKi38o V9QJlrNSfmYWPXHxb6Dy4OEdYkvQEyosfERTm/aHwGzWwzuvE6TF16L4n4LZCrKGIN44gp4IKdr zZ7WCxWOlmxx9+uXr+p1kfLbU6xK3fqxvXK0niYOAFpbUG48O+7QbwcUCH3ZaqjMsFI3G1yYQsd aaujxxnZLKCC8gZu+qy57AjydxHZDTHR+zH+gKkRpZe4SaI2B+EPvzdT7KyELiHdBj77UVjfzKK yntIfki3O91f03YaL7itPhNtnOyTX9IW0g5hXro9qrggOmQOMQxZVKGYfHSuCcosieOIGh68W2/ 8jH52ve0yiofYJij7+N2WcVIUOApcbZp+ohR1dmks7UwF0leCbHjOXozWtdXCAozrS+90w2Irsq TCP35Y= X-Received: by 2002:a05:6a00:cc1:b0:848:48c6:480c with SMTP id d2e1a72fcca58-84e9325a8dbmr6490256b3a.24.1785314721520; Wed, 29 Jul 2026 01:45:21 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 16:45:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-container] setup: openeuler: use network scripts to setup network To: David Riley , pve-devel@lists.proxmox.com References: <20260706121458.73398-1-wukaiyang@loongfans.cn> <0c3096fd-d398-4b14-923f-8d7941a6df93@gmail.com> Content-Language: en-US From: Kaiyang Wu In-Reply-To: <0c3096fd-d398-4b14-923f-8d7941a6df93@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LMHQ2JNWCMUUFI32HQUTLVRCPN6V3IUP X-Message-ID-Hash: LMHQ2JNWCMUUFI32HQUTLVRCPN6V3IUP X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Gentle ping. For the network stack, since the upstream still prefers legacy network scripts on x86_64 and aarch64, is it OK to just use network scripts for now? Kaiyang On 2026-07-15 17:04, Kaiyang Wu wrote: > On 2026-07-14 16:09, David Riley wrote: >> Please split this up into two commits one focusing on the typo and the >> other >> one fixing the issue. > >> >> This does not work. It does allow the container to be created, but >> it won't set a configured static IP address correctly. >> I tested it with: >> >> cat /etc/os-release >> NAME="openEuler" >> VERSION="24.03 (LTS-SP4)" >> >> I think it should be: >> $self->setup_network_with_network_scripts($conf); >> instead. > > I will address these issues in v2. > >> But I think we need to take this fix in a different direction altogether. >> >> Overriding setup_network here to force legacy network scripts >> bypasses the root cause of the issue. The actual bug is that CentOS.pm >> crashes >> when /etc/redhat-release is missing, which prevents it from choosing the >> correct network setup. >> >> Hardcoding the legacy fallback here should not be the way to go >> forward here. >> OpenEuler already includes and prefers NetworkManager, as listed in the >> linuxcontainers.org yaml you linked [0]. Forcing legacy network scripts >> is not a future proof solution, as it already has been deprecated >> upstream >> (see: RHEL 8 [1]). >> >> So what this patch needs is something similar to the version check in >> CentOS.pm >> using the alternative path /etc/os-release instead. >> >> [0] https://github.com/lxc/lxc-ci/ >> blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L250 >> [1] https://docs.redhat.com/en/documentation/ >> red_hat_enterprise_linux/8/ html/8.4_release_notes/ >> deprecated_functionality#deprecated- functionality_networking > > The upstream yaml still prefers legacy network scripts on x86_64 and > aarch64 [0], despite preferring NetworkManager on armhfp [1]. > > [0] https://github.com/lxc/lxc-ci/ > blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/ > openeuler.yaml#L245-L247 > [1] https://github.com/lxc/lxc-ci/ > blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/ > openeuler.yaml#L256-L257 > > Best, > Kaiyang >