Re: [PATCH datacenter-manager v2 16/20] api-cache: add wrapper type

[Dominik Csapak <d.csapak@proxmox.com>]

On 8/24/26 3:46 PM, Lukas Wagner wrote:
> On Mon Aug 24, 2026 at 2:33 PM CEST, Dominik Csapak wrote:
>> i'm missing a bit here why we need a wrapper around a type we fully
>> control here? couldn't we use NamespacedCache directly?
>>
>> what advantage has wrapping it in this way?
>>
>> To me it's not immediately obvious, so a short sentence
>> in the commit message or as comment on the struct, would be good.
> 
> Sorry, I'll try to add additional justification in the commit message in
> the next iteration.
> 
> NamespacedCache is supposed to be fully generic and eventually be moved
> to a shared crate. ApiCache adds PDM-specific semantics, namely having
> per-remote namespaces and also one global namespace.
> 
> Before, these additional semantics were encoded in the helper functions
> in api_cache.rs (e.g. read_global, read_remote), but since we want to
> put this thing in PdmApplication, the helpers are turned into methods of
> this new wrapper type.
> 
> Hope with this explanation it makes more sense?

yes that makes the patch a bit clearer, thanks for explaining

we could still think about building the namespacing into the
underlying generic cache struct though,

e.g we could have a trait

CachePath {
    fn create_cache_path(&self, input: String) -> String
}

(or similar)

which can be a noop by default, and e.g. pdm can implement a

`NamespacedCache`

that implements it differently


then caller can call directly into the cache object and we don't have to 
have a wrapper struct.

not sure if that's practical though ^^