Re: [PATCH proxmox v2 03/20] api-macro: support shared state extraction type

[Dominik Csapak <d.csapak@proxmox.com>]

one comment inline

On 8/20/26 4:52 PM, Lukas Wagner wrote:
[snip]
>   
> +fn as_state_type(ty: &syn::Type) -> Option<StateParameter> {
> +    if let syn::Type::Path(p) = ty {
> +        if p.qself.is_some() {
> +            return None;
> +        }
> +
> +        if let Some(ps) = p.path.segments.last() {
> +            if ps.ident != "State" {
> +                return None;
> +            }
> +
> +            match &ps.arguments {
> +                syn::PathArguments::AngleBracketed(angle_bracketed_generic_arguments) => {
> +                    if angle_bracketed_generic_arguments.args.len() != 1 {
> +                        return None;
> +                    }
> +
> +                    let generic_argument = angle_bracketed_generic_arguments.args[0].clone();
> +
> +                    match generic_argument {
> +                        syn::GenericArgument::Type(ty) => return Some(StateParameter { ty }),
> +                        _ => return None,
> +                    }
> +                }
> +                _ => return None,
> +            }
> +        }
> +    }
> +
> +    None
> +}

just a nit, but IIUC this method parses all parameters out that have a 
State<xyz> type?


e.g i  couldn't use a myfoo::bar::State<Inner> parameter anymore?

not that i think this is super critical, but maybe some kind
of namespace in the type would be nice?

e.g. PmxAppState<XY> ?

this is a bit longer, but much less chance to collide with other things...