[PATCH datacenter-manager v2 19/20] pdm-config: subscriptions: drop unused accessor functions

[Lukas Wagner <l.wagner@proxmox.com>]

Now that the subscription API handlers reach the config through
PdmApplication instead, the free functions built on top of the global
INSTANCE static are unused. Drop them along with the init() call that
used to populate it.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 lib/pdm-config/src/subscriptions.rs | 39 -----------------------------
 server/src/context/mod.rs           |  1 -
 2 files changed, 40 deletions(-)

diff --git a/lib/pdm-config/src/subscriptions.rs b/lib/pdm-config/src/subscriptions.rs
index 5be88a13..c4b99d25 100644
--- a/lib/pdm-config/src/subscriptions.rs
+++ b/lib/pdm-config/src/subscriptions.rs
@@ -7,8 +7,6 @@
 //! entries, which is intended as future proofing for a more automated (shop) import without having
 //! to adapt the data layer.
 
-use std::sync::OnceLock;
-
 use anyhow::Error;
 
 use proxmox_config_digest::ConfigDigest;
@@ -25,37 +23,6 @@ pub const SUBSCRIPTIONS_CFG_FILENAME: &str = configdir!("/subscriptions/keys.cfg
 const SUBSCRIPTIONS_SHADOW_FILENAME: &str = configdir!("/subscriptions/keys.shadow");
 pub const SUBSCRIPTIONS_CFG_LOCKFILE: &str = configdir!("/subscriptions/.keys.lock");
 
-static INSTANCE: OnceLock<Box<dyn SubscriptionKeyConfig + Send + Sync>> = OnceLock::new();
-
-fn instance() -> &'static (dyn SubscriptionKeyConfig + Send + Sync) {
-    INSTANCE
-        .get()
-        .expect("subscription key config not initialized")
-        .as_ref()
-}
-
-pub fn lock_config() -> Result<ApiLockGuard, Error> {
-    instance().lock()
-}
-
-pub fn config() -> Result<(SectionConfigData<SubscriptionKeyEntry>, ConfigDigest), Error> {
-    instance().read()
-}
-
-pub fn shadow_config() -> Result<SectionConfigData<SubscriptionKeyShadow>, Error> {
-    instance().read_shadow()
-}
-
-pub fn save_config(
-    config: &SectionConfigData<SubscriptionKeyEntry>,
-) -> Result<ConfigDigest, Error> {
-    instance().write(config)
-}
-
-pub fn save_shadow(shadow: &SectionConfigData<SubscriptionKeyShadow>) -> Result<(), Error> {
-    instance().write_shadow(shadow)
-}
-
 pub trait SubscriptionKeyConfig {
     fn read(&self) -> Result<(SectionConfigData<SubscriptionKeyEntry>, ConfigDigest), Error>;
     fn read_shadow(&self) -> Result<SectionConfigData<SubscriptionKeyShadow>, Error>;
@@ -110,9 +77,3 @@ impl SubscriptionKeyConfig for DefaultSubscriptionKeyConfig {
         replace_secret_config(SUBSCRIPTIONS_SHADOW_FILENAME, raw.as_bytes())
     }
 }
-
-pub fn init(instance: Box<dyn SubscriptionKeyConfig + Send + Sync>) {
-    if INSTANCE.set(instance).is_err() {
-        panic!("subscription key config instance already set");
-    }
-}
diff --git a/server/src/context/mod.rs b/server/src/context/mod.rs
index 291b6d45..290c1022 100644
--- a/server/src/context/mod.rs
+++ b/server/src/context/mod.rs
@@ -36,7 +36,6 @@ pub fn init() -> Result<PdmApplication, Error> {
     // anyway, and the implementation is stateless, so having this second
     // instance is not an issue *currently*.
     pdm_config::remotes::init(factory.make_remote_config()?);
-    pdm_config::subscriptions::init(factory.make_subscription_key_config()?);
 
     Ok(app)
 }
-- 
2.47.3