Re: [PATCH datacenter-manager v2 14/20] tests: add helpers for building API-handler-level integration tests

["Lukas Wagner" <l.wagner@proxmox.com>]

On Fri Aug 21, 2026 at 11:57 AM CEST, Thomas Ellmenreich wrote:
> I tried to set up a quick tests just to see how everything worked and it
> looks good, only noticed on thing.
>
> On Thu Aug 20, 2026 at 4:52 PM CEST, Lukas Wagner wrote:
>
> [snip]
>
>> +macro_rules! test_pve_client {
>> +    ($ty:ident { $($overrides:tt)* }) => {
>> +
>> +        pub struct $ty(crate::common::PveTestRemote);
>> +
>> +        #[async_trait::async_trait]
>> +        impl pve_api_types::client::PveClient for $ty {
>> +            async fn list_nodes(
>> +                &self,
>> +            ) -> Result<Vec<pve_api_types::ClusterNodeIndexResponse>, proxmox_client::Error> {
>> +                let mut nodes = Vec::new();
>> +
>> +                for i in 0..self.0.nodes {
>> +                    nodes.push(ClusterNodeIndexResponse {
>                                   ^
>                                   Here, you forgot to add `pve_api_types::`,
>                                   forcing the user of the macro to import it.
>                                   This means you can probably also remove the
>                                   import of `ClusterNodeIndexResponse` from
>                                   your tests.

Good catch, thanks!

>
>> +                        cpu: Some(0.0),
>> +                        level: None,
>> +                        maxcpu: Some(4),
>> +                        maxmem: Some(4096),
>> +                        mem: Some(1000),
>> +                        node: format!("{}-node-{i}", self.0.name),
>> +                        ssl_fingerprint: None,
>> +                        status: pve_api_types::ClusterNodeIndexResponseStatus::Online,
>> +                        uptime: Some(1000),
>> +                    });
>> +                }
>> +
>> +                Ok(nodes)
>> +            }
>> +            $($overrides)*
>> +        }
>> +
>> +        impl $ty {
>> +            /// Name of the remote this client was created for.
>> +            pub fn remote(&self) -> &str {
>> +                &self.0.name
>> +            }
>> +
>> +            /// Shared state of the remote this client was created for.
>> +            pub fn state(&self) -> crate::common::TestRemoteState {
>> +                self.0.state.clone()
>> +            }
>> +        }
>> +    };
>> +}
>> +
>> +pub(crate) use test_pve_client;