* [PATCH proxmox] fix #7723: network-api: avoid overwriting existing inet6 family method
@ 2026-06-22 12:06 Shan Shaji
2026-10-02 12:12 ` Shan Shaji
0 siblings, 1 reply; 2+ messages in thread
From: Shan Shaji @ 2026-06-22 12:06 UTC (permalink / raw)
To: pdm-devel
If the inet6 address family's cidr6/gatway6 values are not present, the
interface.method6 values is mutated with `NetworkConfigMethod::Manual`
even if the interface.method6 already has a value. For example, if
the config method is `auto` then it gets replaced by `Manual` config
method.
Later, when writing the config file to the interfaces.new file if the
config method is manual and if there are no IPv6 specific attributes
present, then the inet6 stanza gets skipped.
In order to fix the issue update the condition to only set the config
method to `::Manual` if there is no value present inside the `method6`
property of the interface object.
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
note: The issue where the UI showed an error has already been fixed
in commit (#973cf333).
proxmox-network-api/src/api_impl.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-network-api/src/api_impl.rs b/proxmox-network-api/src/api_impl.rs
index 9d956e2c..ee78a88c 100644
--- a/proxmox-network-api/src/api_impl.rs
+++ b/proxmox-network-api/src/api_impl.rs
@@ -332,7 +332,7 @@ pub fn update_interface(
if interface.cidr6.is_some() || interface.gateway6.is_some() {
interface.method6 = Some(NetworkConfigMethod::Static);
- } else {
+ } else if interface.method6.is_none() {
interface.method6 = Some(NetworkConfigMethod::Manual);
}
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH proxmox] fix #7723: network-api: avoid overwriting existing inet6 family method
2026-06-22 12:06 [PATCH proxmox] fix #7723: network-api: avoid overwriting existing inet6 family method Shan Shaji
@ 2026-10-02 12:12 ` Shan Shaji
0 siblings, 0 replies; 2+ messages in thread
From: Shan Shaji @ 2026-10-02 12:12 UTC (permalink / raw)
To: Shan Shaji, pdm-devel
gentle ping, this still applies.
On Mon Jun 22, 2026 at 2:06 PM CEST, Shan Shaji wrote:
> If the inet6 address family's cidr6/gatway6 values are not present, the
> interface.method6 values is mutated with `NetworkConfigMethod::Manual`
> even if the interface.method6 already has a value. For example, if
> the config method is `auto` then it gets replaced by `Manual` config
> method.
>
> Later, when writing the config file to the interfaces.new file if the
> config method is manual and if there are no IPv6 specific attributes
> present, then the inet6 stanza gets skipped.
>
> In order to fix the issue update the condition to only set the config
> method to `::Manual` if there is no value present inside the `method6`
> property of the interface object.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
> note: The issue where the UI showed an error has already been fixed
> in commit (#973cf333).
>
> proxmox-network-api/src/api_impl.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-network-api/src/api_impl.rs b/proxmox-network-api/src/api_impl.rs
> index 9d956e2c..ee78a88c 100644
> --- a/proxmox-network-api/src/api_impl.rs
> +++ b/proxmox-network-api/src/api_impl.rs
> @@ -332,7 +332,7 @@ pub fn update_interface(
>
> if interface.cidr6.is_some() || interface.gateway6.is_some() {
> interface.method6 = Some(NetworkConfigMethod::Static);
> - } else {
> + } else if interface.method6.is_none() {
> interface.method6 = Some(NetworkConfigMethod::Manual);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-02 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-22 12:06 [PATCH proxmox] fix #7723: network-api: avoid overwriting existing inet6 family method Shan Shaji
2026-10-02 12:12 ` Shan Shaji
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.